Add state badges#169
Merged
Merged
Conversation
df3f101 to
364023a
Compare
Member
|
@jrauh01 Please rebase. |
364023a to
2bc23ce
Compare
Contributor
Author
|
I added a short PR description, about what has changed. |
BastianLedererIcinga
left a comment
Contributor
There was a problem hiding this comment.
The feature works fine.
2bc23ce to
f7caab8
Compare
Contributor
Author
|
In addition to the requested changes I rebased this branch on main. |
BastianLedererIcinga
previously approved these changes
Mar 24, 2026
BastianLedererIcinga
left a comment
Contributor
There was a problem hiding this comment.
Looks good now, @lippserd I'll leave up to you how you want the docs to be adjusted.
f93366d to
fb95383
Compare
Contributor
Author
|
I just squashed the fixup commits. Temporary change has been undone, so this did not change anything. |
fb95383 to
ef97807
Compare
BastianLedererIcinga
approved these changes
Mar 25, 2026
Reformat `module.less` for consistent indentation and add a dedicated `state-badges.less` stylesheet. Register the new stylesheet in `run.php` so it is loaded by the module.
ef97807 to
fcef7f4
Compare
Move `makeBadgeHtml()` and `renderIdoCubeBadges()` into the `CubeRenderer` base class to avoid duplication across host and service renderers. Build on this to render state summary badges (`ok`, `warning`, `critical`, `unknown`, `up`, `down`) for Icinga DB backed cubes.
Dimension headers in the cube now link to the corresponding Icinga DB host or service list, filtered to the current slice. This gives users a quick way to jump from the cube to the detailed object list.
Replace string-based HTML rendering with ipl-html components. Add PHP type declarations to properties and methods. Extract dimension rendering into dedicated `DimensionWidget`, `HostDimensionWidget` and `ServiceDimensionWidget` classes to separate concerns.
Give handled-state titles a muted color scheme so they are visually distinct from unhandled states. This makes it easier to spot unhandled problems at a glance when scanning the cube.
Include the pending state in host and service status cube queries and render it in the state badge rows.
Display unhandled and handled state badges on separate rows so the cube stays readable when many states are present. Adjust CSS grid layout accordingly.
fcef7f4 to
2256fdc
Compare
Remove obsolete screenshots that no longer reflect the current UI and add a single up-to-date overview image. Remove "marketing" stuff from README and About page.
2256fdc to
d66a927
Compare
lippserd
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The whole box color is changed to the state color with the highest precedence (the color of the badge in the center).
Clickable state badges were added to access the corresponding prefiltered lists directly.
Additionally the following has been done:
This feature only supports Icinga DB, because we don't want to support IDO anymore.
resolve #138
resolve #168