Skip to content

Unhide imports from Choices when doing multiedit#2867

Open
arjanoosting wants to merge 2 commits into
Icinga:masterfrom
arjanoosting:unhide-choices-from-imports-on-multiedit
Open

Unhide imports from Choices when doing multiedit#2867
arjanoosting wants to merge 2 commits into
Icinga:masterfrom
arjanoosting:unhide-choices-from-imports-on-multiedit

Conversation

@arjanoosting

Copy link
Copy Markdown

When doing an multiedit the Choises are not shown but the corresponding Host templates are filtered from the imports.
And if you then do a save the imports are removed from the hosts. see issue #1203

This small patch unhides the filtered host templates when doing an multiedit.

The nicer solution is showing the choices as well in the multiedit, but that is much more complicated code change :)

@cla-bot

cla-bot Bot commented Feb 8, 2024

Copy link
Copy Markdown

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @arjanoosting

Details
  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@bobapple

bobapple commented Feb 8, 2024

Copy link
Copy Markdown
Member

@cla-bot check

@cla-bot cla-bot Bot added the cla/signed label Feb 8, 2024
@lippserd

Copy link
Copy Markdown
Member

@raviks789 Please check this PR.

@raviks789

Copy link
Copy Markdown
Collaborator

@lippserd I'm not entirely sure I understand the issue.

@raviks789 raviks789 removed their assignment Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants