Expose display_name field in the service form#3078
Open
Fantu wants to merge 1 commit into
Open
Conversation
The `display_name` property already exists on `IcingaService` and is rendered into the generated config, but the web form never exposed it, so it could only be set through manual SQL or the REST API. This adds a `Display name` text field to the service form, mirroring the existing host form behaviour. A dedicated `addDisplayNameElement()` is added and wired into all three setup paths (service objects and apply rules, host-related services and service-set services), skipping templates just like the host form does. Fixes Icinga#608 Fixes Icinga#2659 Fixes Icinga#2957 Refs Icinga#932 Refs Icinga#2509 Assisted-by: Claude Code (Opus 4.8) Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
|
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @Fantu Details
|
Author
|
cla was signed |
Member
|
@cla-bot check |
Author
|
@bobapple thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
display_nameproperty already exists onIcingaServiceand is rendered into the generated config, but the web form never exposed it, so it could only be set through manual SQL or the REST API. This adds aDisplay nametext field to the service form, mirroring the existing host form behaviour.A dedicated
addDisplayNameElement()is added and wired into all three setup paths (service objects and apply rules, host-related services and service-set services), skipping templates just like the host form does.Fixes #608
Fixes #2659
Fixes #2957
Refs #932
Refs #2509