Handle carbonapi expand failures#348
Merged
Merged
Conversation
go-carbon releases up to v0.19.1 can return HTTP 500 instead of 404 for missing carbonserver find results. carbonapi cannot apply notFoundStatusCode normalization in that case, so metrics/expand surfaces the backend failure. Treat those template-probing failures like an empty match set so unrelated templates can still render.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat carbonapi backend 500 responses during metrics expansion as empty result sets. This keeps template probing from failing the whole graph render when older go-carbon releases return 500 instead of 404 for missing carbonserver find results.