GitHub Actions: Use new PHP workflow (#82)

This PR switches to the new PHP workflow, which combines linting, static
analysis, and unit testing. `phpcs.xml` file has been removed because
the new workflow provides a default config for it and the file did not
contain any special configurations anyway. Code style corrections were
made to comply with the latest PSR coding standards. In addition, allow
GitHub Actions workflow to run for every pull request instead of only
main-based pull requests.

Author: lippserd

.github/workflows/php.yml

@@ -1,42 +1,13 @@
-name: PHP Tests
+name: CI
 
 on:
   push:
     branches:
       - main
-      - release/*
+      - support/*
   pull_request:
-    branches:
-      - main
 
 jobs:
-  lint:
-    name: Static analysis for php ${{ matrix.php }} on ${{ matrix.os }}
-    runs-on: ${{ matrix.os }}
-
-    strategy:
-      fail-fast: false
-      matrix:
-        php: ['8.2', '8.3', '8.4']
-        os: ['ubuntu-latest']
-
-    steps:
-      - name: Checkout code base
-        uses: actions/checkout@v4
-
-      - name: Setup PHP
-        uses: shivammathur/setup-php@v2
-        with:
-          php-version: ${{ matrix.php }}
-          tools: phpcs
-
-      - name: Setup dependencies
-        run: composer require -n --no-progress overtrue/phplint
-
-      - name: PHP Lint
-        if: ${{ ! cancelled() }}
-        run: ./vendor/bin/phplint -n --exclude={^vendor/.*} -- .
-
-      - name: PHP CodeSniffer
-        if: ${{ ! cancelled() }}
-        run: phpcs
+  php:
+    name: PHP
+    uses: Icinga/github-actions/.github/workflows/php.yml@main

.github/workflows/phpstan.yml

@@ -27,13 +27,13 @@ class HeadlessChrome
      *
      * First matching group is the used port and the second one the browser id.
      */
-    const DEBUG_ADDR_PATTERN = '/DevTools listening on ws:\/\/((?>\d+\.?){4}:\d+)\/devtools\/browser\/([\w-]+)/';
+    public const DEBUG_ADDR_PATTERN = '/DevTools listening on ws:\/\/((?>\d+\.?){4}:\d+)\/devtools\/browser\/([\w-]+)/';
 
     /** @var string */
-    const WAIT_FOR_NETWORK = 'wait-for-network';
+    public const WAIT_FOR_NETWORK = 'wait-for-network';
 
     /** @var string Javascript Promise to wait for layout initialization */
-    const WAIT_FOR_LAYOUT = <<<JS
+    public const WAIT_FOR_LAYOUT = <<<JS
 new Promise((fulfill, reject) => {
     let timeoutId = setTimeout(() => reject('fail'), 10000);
 
@@ -519,7 +519,7 @@ private function printToPDF($socket, $browserId, array $parameters)
             $parameters,
             ['transferMode' => 'ReturnAsBase64', 'printBackground' => true]
         ));
-        if (isset($result['data']) && !empty($result['data'])) {
+        if (! empty($result['data'])) {
             $pdf = base64_decode($result['data']);
         } else {
             throw new Exception('Expected base64 data. Got instead: ' . json_encode($result));

.phpcs.xml

@@ -17,7 +17,7 @@
 class PrintableHtmlDocument extends BaseHtmlElement
 {
     /** @var string */
-    const DEFAULT_HEADER_FOOTER_STYLE = <<<'CSS'
+    public const DEFAULT_HEADER_FOOTER_STYLE = <<<'CSS'
 @font-face {
   font-family: "Helvetica Neue", "Helvetica", "Arial", sans-serif;
 }