Close Chrome process pipes before termination to prevent loop hang#94
Merged
Conversation
Chrome spawns renderer and utility sub-processes that inherit the open stdin, stdout, and stderr pipes of the main browser process. When only the main process is terminated via `Process::terminate()`, those child processes keep the inherited file descriptors open. ReactPHP's event loop stays alive watching those streams, so `Loop::run()` never returns and PDF generation hangs indefinitely. Close all process pipes explicitly before calling `terminate()` so the event loop has no remaining streams to watch and can exit cleanly. Co-authored-by: OoYo0uto <253079834+OoYo0uto@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrome spawns renderer and utility sub-processes that inherit the open stdin, stdout, and stderr pipes of the main browser process. When only the main process is terminated via
Process::terminate(), those child processes keep the inherited file descriptors open. ReactPHP's event loop stays alive watching those streams, soLoop::run()never returns and PDF generation hangs indefinitely.Close all process pipes explicitly before calling
terminate()so the event loop has no remaining streams to watch and can exit cleanly.