Throw exception if pdfexport module is missing

Author: TheSyscall

application/clicommands/DownloadCommand.php

@@ -6,6 +6,7 @@
 namespace Icinga\Module\Reporting\Clicommands;
 
 use Icinga\Application\Hook\PdfexportHook;
+use Icinga\Application\Modules\Module;
 use Icinga\Exception\NotFoundError;
 use Icinga\Module\Pdfexport\ProvidedHook\Pdfexport;
 use Icinga\Module\Reporting\Cli\Command;
@@ -15,6 +16,7 @@
 use Icinga\Util\Environment;
 use InvalidArgumentException;
 use ipl\Stdlib\Filter;
+use RuntimeException;
 
 class DownloadCommand extends Command
 {
@@ -72,6 +74,10 @@ public function defaultAction()
         switch ($format) {
             case 'pdf':
                 // TODO: Remove this once the dependency on the Pdfexport module is removed
+                if (! Module::exists('pdfexport')) {
+                    throw new RuntimeException('The pdfexport module is not installed');
+                }
+
                 /** @var PdfexportHook $exporter */
                 $exporter = method_exists(PdfexportHook::class, 'first')
                     ? PdfexportHook::first()

application/controllers/ReportController.php

@@ -6,7 +6,6 @@
 namespace Icinga\Module\Reporting\Controllers;
 
 use Exception;
-use Icinga\Application\Hook;
 use Icinga\Application\Hook\PdfexportHook;
 use Icinga\Application\Modules\Module;
 use Icinga\Module\Pdfexport\ProvidedHook\Pdfexport;
@@ -26,6 +25,7 @@
 use ipl\Web\Widget\ActionBar;
 use Icinga\Util\Environment;
 use ipl\Web\Widget\ActionLink;
+use RuntimeException;
 
 class ReportController extends Controller
 {
@@ -248,7 +248,7 @@ public function downloadAction(): void
             case 'pdf':
                 // TODO: Remove this once the dependency on the Pdfexport module is removed
                 if (! Module::exists('pdfexport')) {
-                    throw new Exception('The pdfexport module is not installed');
+                    throw new RuntimeException('The pdfexport module is not installed');
                 }
 
                 /** @var PdfexportHook $exporter */

library/Reporting/Actions/SendMail.php

@@ -7,6 +7,7 @@
 
 use Icinga\Application\Config;
 use Icinga\Application\Hook\PdfexportHook;
+use Icinga\Application\Modules\Module;
 use Icinga\Module\Pdfexport\ProvidedHook\Pdfexport;
 use Icinga\Module\Reporting\Hook\ActionHook;
 use Icinga\Module\Reporting\Mail;
@@ -15,6 +16,7 @@
 use ipl\Stdlib\Str;
 use ipl\Validator\CallbackValidator;
 use ipl\Validator\EmailAddressValidator;
+use RuntimeException;
 
 class SendMail extends ActionHook
 {
@@ -49,6 +51,10 @@ public function execute(Report $report, array $config)
         switch ($config['type']) {
             case 'pdf':
                 // TODO: Remove this once the dependency on the Pdfexport module is removed
+                if (! Module::exists('pdfexport')) {
+                    throw new RuntimeException('The pdfexport module is not installed');
+                }
+
                 /** @var PdfexportHook $exporter */
                 $exporter = method_exists(PdfexportHook::class, 'first')
                     ? PdfexportHook::first()