Skip to content

Commit b04f85d

Browse files
sukhwinder33445sukhwinder33445
committed
Phpstan: Cleanup baseline and remove superfluous type hints
1 parent a574428 commit b04f85d

5 files changed

Lines changed: 0 additions & 98 deletions

File tree

‎library/Reporting/Web/Forms/ReportForm.php‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
use Icinga\Authentication\Auth;
88
use Icinga\Module\Reporting\Database;
99
use Icinga\Module\Reporting\ProvidedReports;
10-
use ipl\Html\Contract\FormSubmitElement;
1110
use ipl\Html\Form;
1211
use ipl\Html\HtmlDocument;
1312
use ipl\Validator\CallbackValidator;
@@ -167,7 +166,6 @@ protected function assemble()
167166
]);
168167

169168
if ($this->id !== null) {
170-
/** @var FormSubmitElement $removeButton */
171169
$removeButton = $this->createElement('submit', 'remove', [
172170
'label' => $this->translate('Remove Report'),
173171
'class' => 'btn-remove',

‎library/Reporting/Web/Forms/ScheduleForm.php‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
use Icinga\Module\Reporting\ProvidedActions;
1414
use Icinga\Module\Reporting\Report;
1515
use Icinga\Util\Json;
16-
use ipl\Html\Contract\FormSubmitElement;
1716
use ipl\Html\Form;
1817
use ipl\Html\HtmlDocument;
1918
use ipl\Html\HtmlElement;
@@ -130,7 +129,6 @@ protected function assemble()
130129
$wrapper = $this->getElement('submit')->getWrapper();
131130
$wrapper->prepend($sendButton);
132131

133-
/** @var FormSubmitElement $removeButton */
134132
$removeButton = $this->createElement('submit', 'remove', [
135133
'label' => $this->translate('Remove Schedule'),
136134
'class' => 'btn-remove',

‎library/Reporting/Web/Forms/TemplateForm.php‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
use Icinga\Authentication\Auth;
1010
use Icinga\Module\Reporting\Database;
1111
use Icinga\Util\Json;
12-
use ipl\Html\Contract\FormSubmitElement;
1312
use ipl\Html\Html;
1413
use ipl\Html\HtmlDocument;
1514
use ipl\Web\Compat\CompatForm;
@@ -139,7 +138,6 @@ protected function assemble()
139138
]);
140139

141140
if ($this->template !== null) {
142-
/** @var FormSubmitElement $removeButton */
143141
$removeButton = $this->createElement('submit', 'remove', [
144142
'label' => $this->translate('Remove Template'),
145143
'class' => 'btn-remove',

‎library/Reporting/Web/Forms/TimeframeForm.php‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
use DateTime;
88
use Exception;
99
use Icinga\Module\Reporting\Database;
10-
use ipl\Html\Contract\FormSubmitElement;
1110
use ipl\Html\FormElement\LocalDateTimeElement;
1211
use ipl\Html\HtmlDocument;
1312
use ipl\Validator\CallbackValidator;
@@ -166,7 +165,6 @@ protected function assemble()
166165
]);
167166

168167
if ($this->id !== null) {
169-
/** @var FormSubmitElement $removeButton */
170168
$removeButton = $this->createElement('submit', 'remove', [
171169
'label' => $this->translate('Remove Time Frame'),
172170
'class' => 'btn-remove',

‎phpstan-baseline.neon‎

Lines changed: 0 additions & 90 deletions
Original file line numberDiff line numberDiff line change
@@ -70,51 +70,6 @@ parameters:
7070
count: 1
7171
path: application/clicommands/ScheduleCommand.php
7272

73-
-
74-
message: "#^Method Icinga\\\\Module\\\\Reporting\\\\Controllers\\\\ConfigController\\:\\:backendAction\\(\\) has no return type specified\\.$#"
75-
count: 1
76-
path: application/controllers/ConfigController.php
77-
78-
-
79-
message: "#^Method Icinga\\\\Module\\\\Reporting\\\\Controllers\\\\ConfigController\\:\\:mailAction\\(\\) has no return type specified\\.$#"
80-
count: 1
81-
path: application/controllers/ConfigController.php
82-
83-
-
84-
message: "#^Method Icinga\\\\Module\\\\Reporting\\\\Controllers\\\\ReportController\\:\\:assembleActions\\(\\) has no return type specified\\.$#"
85-
count: 1
86-
path: application/controllers/ReportController.php
87-
88-
-
89-
message: "#^Method Icinga\\\\Module\\\\Reporting\\\\Controllers\\\\ReportController\\:\\:cloneAction\\(\\) has no return type specified\\.$#"
90-
count: 1
91-
path: application/controllers/ReportController.php
92-
93-
-
94-
message: "#^Method Icinga\\\\Module\\\\Reporting\\\\Controllers\\\\ReportController\\:\\:downloadAction\\(\\) has no return type specified\\.$#"
95-
count: 1
96-
path: application/controllers/ReportController.php
97-
98-
-
99-
message: "#^Method Icinga\\\\Module\\\\Reporting\\\\Controllers\\\\ReportController\\:\\:editAction\\(\\) has no return type specified\\.$#"
100-
count: 1
101-
path: application/controllers/ReportController.php
102-
103-
-
104-
message: "#^Method Icinga\\\\Module\\\\Reporting\\\\Controllers\\\\ReportController\\:\\:indexAction\\(\\) has no return type specified\\.$#"
105-
count: 1
106-
path: application/controllers/ReportController.php
107-
108-
-
109-
message: "#^Method Icinga\\\\Module\\\\Reporting\\\\Controllers\\\\ReportController\\:\\:scheduleAction\\(\\) has no return type specified\\.$#"
110-
count: 1
111-
path: application/controllers/ReportController.php
112-
113-
-
114-
message: "#^Method Icinga\\\\Module\\\\Reporting\\\\Controllers\\\\ReportController\\:\\:sendAction\\(\\) has no return type specified\\.$#"
115-
count: 1
116-
path: application/controllers/ReportController.php
117-
11873
-
11974
message: "#^Parameter \\#2 \\$value of static method ipl\\\\Stdlib\\\\Filter\\:\\:equal\\(\\) expects array\\|bool\\|float\\|int\\|string, mixed given\\.$#"
12075
count: 1
@@ -125,26 +80,6 @@ parameters:
12580
count: 1
12681
path: application/controllers/ReportsController.php
12782

128-
-
129-
message: "#^Method Icinga\\\\Module\\\\Reporting\\\\Controllers\\\\ReportsController\\:\\:indexAction\\(\\) has no return type specified\\.$#"
130-
count: 1
131-
path: application/controllers/ReportsController.php
132-
133-
-
134-
message: "#^Method Icinga\\\\Module\\\\Reporting\\\\Controllers\\\\ReportsController\\:\\:newAction\\(\\) has no return type specified\\.$#"
135-
count: 1
136-
path: application/controllers/ReportsController.php
137-
138-
-
139-
message: "#^Method Icinga\\\\Module\\\\Reporting\\\\Controllers\\\\TemplateController\\:\\:editAction\\(\\) has no return type specified\\.$#"
140-
count: 1
141-
path: application/controllers/TemplateController.php
142-
143-
-
144-
message: "#^Method Icinga\\\\Module\\\\Reporting\\\\Controllers\\\\TemplateController\\:\\:indexAction\\(\\) has no return type specified\\.$#"
145-
count: 1
146-
path: application/controllers/TemplateController.php
147-
14883
-
14984
message: "#^Parameter \\#2 \\$value of static method ipl\\\\Stdlib\\\\Filter\\:\\:equal\\(\\) expects array\\|bool\\|float\\|int\\|string, mixed given\\.$#"
15085
count: 1
@@ -155,21 +90,6 @@ parameters:
15590
count: 2
15691
path: application/controllers/TemplatesController.php
15792

158-
-
159-
message: "#^Method Icinga\\\\Module\\\\Reporting\\\\Controllers\\\\TemplatesController\\:\\:indexAction\\(\\) has no return type specified\\.$#"
160-
count: 1
161-
path: application/controllers/TemplatesController.php
162-
163-
-
164-
message: "#^Method Icinga\\\\Module\\\\Reporting\\\\Controllers\\\\TemplatesController\\:\\:newAction\\(\\) has no return type specified\\.$#"
165-
count: 1
166-
path: application/controllers/TemplatesController.php
167-
168-
-
169-
message: "#^Method Icinga\\\\Module\\\\Reporting\\\\Controllers\\\\TimeframeController\\:\\:editAction\\(\\) has no return type specified\\.$#"
170-
count: 1
171-
path: application/controllers/TimeframeController.php
172-
17393
-
17494
message: "#^Parameter \\#2 \\$value of static method ipl\\\\Stdlib\\\\Filter\\:\\:equal\\(\\) expects array\\|bool\\|float\\|int\\|string, mixed given\\.$#"
17595
count: 1
@@ -205,16 +125,6 @@ parameters:
205125
count: 1
206126
path: application/controllers/TimeframesController.php
207127

208-
-
209-
message: "#^Method Icinga\\\\Module\\\\Reporting\\\\Controllers\\\\TimeframesController\\:\\:indexAction\\(\\) has no return type specified\\.$#"
210-
count: 1
211-
path: application/controllers/TimeframesController.php
212-
213-
-
214-
message: "#^Method Icinga\\\\Module\\\\Reporting\\\\Controllers\\\\TimeframesController\\:\\:newAction\\(\\) has no return type specified\\.$#"
215-
count: 1
216-
path: application/controllers/TimeframesController.php
217-
218128
-
219129
message: "#^Method Icinga\\\\Module\\\\Reporting\\\\Forms\\\\ConfigureMailForm\\:\\:createElements\\(\\) has no return type specified\\.$#"
220130
count: 1

0 commit comments

Comments
 (0)