Conditional report actions#276
Open
TheSyscall wants to merge 3 commits intomainfrom
Open
Conversation
Al2Klimov
reviewed
Apr 16, 2026
| 'forward' | ||
| ))->openInModal() | ||
| ); | ||
| if ($download->hasLinks()) { |
Member
There was a problem hiding this comment.
Requires:
I'll keep this thread open, so we don't forget. Also, you should bump the module.info to a not yet released ipl version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only show actions if there is actually an exporter for it.
This serves as a step toward getting rid of pdfexport as a requirement for reporting, but does not get rid of this dependency entirely.
This combined with the changes made in #275 should allow us to remove pdfexport as a requirement entirely
requires Icinga/ipl-web#367
relates to #275