Remove superfluous remove array

jrauh01 · jrauh01 · commit 767dab4ee1f2 · 2026-02-27T14:55:12.000+01:00
diff --git a/library/Vspheredb/Daemon/RpcNamespace/RpcNamespaceLogger.php b/library/Vspheredb/Daemon/RpcNamespace/RpcNamespaceLogger.php
@@ -40,15 +40,11 @@ public function setLogLevelRequest($level)
             $this->logger->notice("Will change the log level to '$level'");
         }
         $this->logger->addFilter($newFilter);
-        $remove = [];
         foreach ($this->logger->getFilters() as $filter) {
             if ($filter instanceof LogLevelFilter && $filter !== $newFilter) {
-                $remove[] = $filter;
+                $this->logger->removeFilter($filter);
             }
         }
-        foreach ($remove as $filter) {
-            $this->logger->removeFilter($filter);
-        }
         if ($newFilter->wants('notice', '')) {
             $this->logger->notice("Changed log level to '$level'");
         }

Original file line number	Diff line number	Diff line change
`@@ -40,15 +40,11 @@ public function setLogLevelRequest($level)`
`40`	`40`	`$this->logger->notice("Will change the log level to '$level'");`
`41`	`41`	`}`
`42`	`42`	`$this->logger->addFilter($newFilter);`
`43`		`- $remove = [];`
`44`	`43`	`foreach ($this->logger->getFilters() as $filter) {`
`45`	`44`	`if ($filter instanceof LogLevelFilter && $filter !== $newFilter) {`
`46`		`- $remove[] = $filter;`
	`45`	`+ $this->logger->removeFilter($filter);`
`47`	`46`	`}`
`48`	`47`	`}`
`49`		`- foreach ($remove as $filter) {`
`50`		`- $this->logger->removeFilter($filter);`
`51`		`- }`
`52`	`48`	`if ($newFilter->wants('notice', '')) {`
`53`	`49`	`$this->logger->notice("Changed log level to '$level'");`
`54`	`50`	`}`