Replace deprecated React\EventLoop\Factory::create()

Replace with `React\EventLoop\Loop::get()`. The single instance guard around the
deprecated function call can be avoided now, because this is already done inside
the new function.

Author: jrauh01

application/clicommands/Command.php

@@ -14,7 +14,7 @@
 use Icinga\Cli\Command as CliCommand;
 use Icinga\Module\Vspheredb\Configuration;
 use Icinga\Module\Vspheredb\Daemon\RemoteClient;
-use React\EventLoop\Factory as Loop;
+use React\EventLoop\Loop;
 use React\EventLoop\LoopInterface;
 use React\Stream\WritableResourceStream;
 
@@ -39,11 +39,7 @@ public function init()
 
     protected function loop()
     {
-        if ($this->loop === null) {
-            $this->loop = Loop::create();
-        }
-
-        return $this->loop;
+        return Loop::get();
     }
 
     protected function eventuallyStartMainLoop()

application/controllers/AsyncControllerHelper.php

@@ -4,15 +4,13 @@
 
 use Icinga\Module\Vspheredb\Configuration;
 use Icinga\Module\Vspheredb\Daemon\RemoteClient;
-use React\EventLoop\Factory as Loop;
+use React\EventLoop\Loop;
 
 use function React\Async\await;
 use function React\Promise\Timer\timeout;
 
 trait AsyncControllerHelper
 {
-    protected $loop;
-
     /** @var RemoteClient */
     protected $remoteClient;
 
@@ -35,11 +33,6 @@ protected function remoteClient()
 
     protected function loop()
     {
-        // Hint: we're not running this loop right now
-        if ($this->loop === null) {
-            $this->loop = Loop::create();
-        }
-
-        return $this->loop;
+        return Loop::get();
     }
 }