Adapt to IPL strict typing in forms and i18n helpers#617
Merged
Conversation
Recent versions of Icinga PHP Library introduce strict typing that is not satisfied by using `EventEmitterTrait` directly.
The module previously depended on `gipfl\Translation\TranslationHelper` for i18n support in UI classes. `ipl\I18n\Translation` is the equivalent trait from the IPL library, which the module already uses broadly for other concerns, making the gipfl dependency redundant.
lippserd
added a commit
that referenced
this pull request
Mar 28, 2026
Use `ipl\Stdlib\Events` in form subclasses to satisfy IPL’s strict typing, which is not met by using `EventEmitterTrait` directly. Replace `gipfl\Translation\TranslationHelper` with `ipl\I18n\Translation` for i18n support in UI classes. The module already uses IPL broadly for other concerns, so this removes a redundant dependency and aligns with IPL’s strict‑typing requirements. (cherry picked from commit 13e4dcb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
ipl\Stdlib\Eventsin form subclasses to satisfy IPL’s strict typing,which is not met by using
EventEmitterTraitdirectly.Replace
gipfl\Translation\TranslationHelperwithipl\I18n\Translationfori18n support in UI classes. The module already uses IPL broadly for other
concerns, so this removes a redundant dependency and aligns with IPL’s
strict‑typing requirements.
fixes #616