Fix/type error null parentuuid in monitoring rules tree#632
Open
Wintermute2k6 wants to merge 3 commits into
Open
Fix/type error null parentuuid in monitoring rules tree#632Wintermute2k6 wants to merge 3 commits into
Wintermute2k6 wants to merge 3 commits into
Conversation
…me which leads to division by zero - Customer suggested changes in VmDiskUsageTable.php and SimpleUsageBar.php tried to fix indention fixed typo fixed typo fixed indention fixed indention
…turns zero to MonitoringRuleSet::loadOptionalForUuid(string $uuid), when an object has no parent_uuid. With PHP 8.x the leads to an TypeError and also blocks Rule-Refreshing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
customer suggestion of the following fix ref/nc/895761
MonitoringRulesTree::getInheritedSettingsFor() returns zero to MonitoringRuleSet::loadOptionalForUuid(string $uuid), when an object has no parent_uuid. With PHP 8.x the leads to an TypeError and also blocks Rule-Refreshing.