Add clickable filter for some objects#636
Open
bmtwl wants to merge 3 commits into
Open
Conversation
Created a one-click filter for VDI, templates and powered off VMs
Changes for clickable snapshot filter feature
fixed style problem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a feature suggestion for filtering out junk or nuisance objects when using the snapshots report to find lingering snapshots
We also run VDI, which means there are lots of snapshots that are expected and that we really don't want cluttering up the report.
I am not a huge fan of the approach in this PR is since it embeds some of our naming patterns and business logic in code, but I thought I'd open it anyways to begin a conversation in case this feature is thought to be generally useful (in which case I wouldn't need to maintain internal patches long-term.)