Module: Expect user and group backends upon registration

Providing a user or user group backend in configuration.php
now triggers a deprecation or warning. They are expected to
be announced in run.php, just like hooks. Authentication
attempts during a configuration.php run, while Authentication
has not been performed yet, will be also suspended now.
This ensures that the current behavior, being broken or
working, stays the same.

refs #5265

Author: nilmerg

doc/80-Upgrading.md

@@ -5,6 +5,12 @@ v2.6 to v2.8 requires to follow the instructions for v2.7 too.
 
 ## Upgrading to Icinga Web 2.14
 
+**Deprecations**
+
+* Providing a custom user or group backend inside a module's configuration.php is deprecated and won't work as of v2.15.
+  * It will still work as previously under the right circumstances, but will still be broken if it broke beforehand.
+  * To keep it working as of v2.15 or make it work now, provide the custom backend inside the module's run.php instead.
+
 **Framework changes affecting third-party code**
 
 * Our JavaScript implementation to update relative times in the UI has been removed from Icinga Web, and an updated

library/Icinga/Application/Modules/Module.php

@@ -6,6 +6,7 @@
 namespace Icinga\Application\Modules;
 
 use Exception;
+use Fiber;
 use Icinga\Application\ApplicationBootstrap;
 use Icinga\Application\Config;
 use Icinga\Application\Hook;
@@ -1084,7 +1085,22 @@ public function getSetupWizard()
      */
     public function getUserBackends()
     {
-        $this->launchConfigScript();
+        // TODO: Remove with v2.15
+        if (Fiber::getCurrent() === null) {
+            (new Fiber(function () {
+                Logger::debug(
+                    'Running config script of module "%s" asynchronously (Process %d; Fiber %d)',
+                    $this->getName(),
+                    getmypid() ?: 0,
+                    spl_object_id(Fiber::getCurrent())
+                );
+
+                $this->launchConfigScript();
+            }))->start();
+        } else {
+            $this->launchConfigScript();
+        }
+
         return $this->userBackends;
     }
 
@@ -1095,7 +1111,22 @@ public function getUserBackends()
      */
     public function getUserGroupBackends()
     {
-        $this->launchConfigScript();
+        // TODO: Remove with v2.15
+        if (Fiber::getCurrent() === null) {
+            (new Fiber(function () {
+                Logger::debug(
+                    'Running config script of module "%s" asynchronously (Process %d; Fiber %d)',
+                    $this->getName(),
+                    getmypid() ?: 0,
+                    spl_object_id(Fiber::getCurrent())
+                );
+
+                $this->launchConfigScript();
+            }))->start();
+        } else {
+            $this->launchConfigScript();
+        }
+
         return $this->userGroupBackends;
     }
 
@@ -1196,6 +1227,21 @@ protected function provideSetupWizard($className)
      */
     protected function provideUserBackend($identifier, $className)
     {
+        if ($this->registered) {
+            trigger_error(sprintf(
+                'Module "%s" already registered. Providing user backend "%s" in configuration.php'
+                . ' has no effect as of version 2.15. Put it in run.php instead.',
+                $this->getName(),
+                $identifier
+            ), E_USER_DEPRECATED);
+            Logger::warning(
+                'Module "%s" already registered. Providing user backend "%s" in configuration.php'
+                . ' has no effect as of version 2.15. Put it in run.php instead.',
+                $this->getName(),
+                $identifier
+            );
+        }
+
         $this->userBackends[strtolower($identifier)] = $className;
         return $this;
     }
@@ -1210,6 +1256,21 @@ protected function provideUserBackend($identifier, $className)
      */
     protected function provideUserGroupBackend($identifier, $className)
     {
+        if ($this->registered) {
+            trigger_error(sprintf(
+                'Module "%s" already registered. Providing user group backend "%s" in configuration.php'
+                . ' has no effect as of version 2.15. Put it in run.php instead.',
+                $this->getName(),
+                $identifier
+            ), E_USER_DEPRECATED);
+            Logger::warning(
+                'Module "%s" already registered. Providing user group backend "%s" in configuration.php'
+                . ' has no effect as of version 2.15. Put it in run.php instead.',
+                $this->getName(),
+                $identifier
+            );
+        }
+
         $this->userGroupBackends[strtolower($identifier)] = $className;
         return $this;
     }