Auth: Persist session before refreshing current logged in user#5162
Open
yhabteab wants to merge 1 commit into
Open
Auth: Persist session before refreshing current logged in user#5162yhabteab wants to merge 1 commit into
yhabteab wants to merge 1 commit into
Conversation
yhabteab
force-pushed
the
fix-shared-cookie
branch
from
d506d71 to
e3a5112
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using external auth, e.g. NGINX basic auth, it's not possible to use the user's session for Nagvis authentication, even though the cookie path is set to
/, which allows another Icinga web instance to access that same cookie. However, as the user's cookie is periodically refreshed, this invalidates the entire session for the third party, resulting in theREMOTE_USERheader being empty.The Application State Controller already does the same thing!
icingaweb2/application/controllers/ApplicationStateController.php
Lines 38 to 40 in cd2daeb
Might fix Icinga/icingaweb2-module-nagvis#35 (I didn't test it as I don't use apache). Using NGINX works fine though. @slalomsk8er can you please verify this if you are still using apache and Nagvis.