Prevent unintentional closing of a modal#5319
Closed
sukhwinder33445 wants to merge 2 commits intomainfrom
Closed
Conversation
sukhwinder33445
changed the title
Al2Klimov
changed the title
Don't close modal if it contains changes and: - `ESCAPE` is pressed - User click on the overlay
nilmerg
force-pushed
the
feature/prevent-unintentional-closing-of-a-model
branch
from
dd1f8e3 to
bec3323
Compare
Member
|
I had to rework this from scratch as most of the changes here didn't fully track the user's changes nor did respect normal user interaction. (i.e. the blur upon pushing Escape to trigger the change event) Opened #5501 as a result. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #5307