Conversation
TheSyscall
added a commit
to Icinga/icingaweb2-module-pdfexport
that referenced
this pull request
Apr 8, 2026
Makes pdfexport compatible with Icinga/icingaweb2#5491
This was referenced Apr 8, 2026
TheSyscall
changed the title
PdfexportHook::htmlToPdf method
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Al2Klimov
reviewed
Apr 16, 2026
TheSyscall
changed the title
PdfexportHook::htmlToPdf methodfirst and htmlToPdf methods to PdfexportHook
Al2Klimov
reviewed
May 21, 2026
Al2Klimov
reviewed
May 21, 2026
Al2Klimov
previously approved these changes
May 22, 2026
lippserd
requested changes
Jun 22, 2026
lippserd
left a comment
lippserd
left a comment
Member
There was a problem hiding this comment.
Please rebase if needed and fixup your commits. It makes sense to mention in the commit message(s) that strict types have been left out on purpose to be compatible with the already existing implementation.
TheSyscall
force-pushed
the
pdf-hook
branch
2 times, most recently
from
9a731d3 to
26e20f4
Compare
It made little sense that we ask a concrete hook implementation for the first implementation of a hook. It essentially limited us to exactly one possible pdfexport extension (our own), which is not how hooks are supposed to work. Strict types have been left out intentionally to stay compatible with the existing imeplementation.
This method was always required because it was called by the reporting module assuming that our own implementation of the pdfexport module was the one chosen. Because this behavior exists and our pdfexport module is the only implementation of this hook this is not a breaking change. Strict types have been left out on purpose to be compatible with the already existing implementation.
This commit also includes phpdoc formating changes. Strict types have been left out on purpose to be compatible with the already existing implementation.
Contributor
Author
|
Reverted implementation of |
lippserd
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two methods to the pdfexport hook:
firstandhtmlToPdfBoth functions were previously called without actually being part of the hook.
The only possible implementation of this hook comes from the pdfexport module which already defines the same two methods.
Intentionally leaving out strict types and
HookEssentialsto be backward compatible with the original hook implementation.