js: Do not trigger rendered for unchanged content#5505
Draft
Conversation
The request object now holds a set that is populated with elements that were updated during ´onResponse`. `onComplete` now uses it to trigger the `rendered` event on each entry. Note that for multipart updates the way the event is triggered has changed slightly. Since multipart updates usually do not contain nested containers, the updated parts never triggered the event and only the main container did. I figured this might be useful, but it isn't necessary to fix the referenced issue. fixes #5377
nilmerg
added
area/javascript
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The request object now holds a set that is populated with elements that were updated during
onResponse.onCompletenow uses it to trigger therenderedevent on each entry.Note that for multipart updates the way the event is triggered has changed slightly. Since multipart updates usually do not contain nested containers, the updated parts never triggered the event and only the main container did. I figured this might be useful, but it isn't necessary to fix the referenced issue.
fixes #5377
--
Still need to check which of our native listeners are affected by this.