Remove dependency on pdfexport module for PDF export#5510
Draft
TheSyscall wants to merge 4 commits into
Draft
Conversation
It made little sense that we ask a concrete hook implementation for the first implementation of a hook. It essentially limited us to exactly one possible pdfexport extension (our own), which is not how hooks are supposed to work.
This method was always required because it was called by the reporting module assuming that our own implementation of the pdfexport module was the one chosen. Because this behavior exists and our pdfexport module is the only implementation of this hook this is not a breaking change.
This commit also includes phpdoc formating changes
TheSyscall
force-pushed
the
pdf-hook
branch
2 times, most recently
from
80cceff to
a2ea423
Compare
TheSyscall
force-pushed
the
pdf-hook
branch
3 times, most recently
from
26e20f4 to
bd3e787
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to remove the hard dependency on our own pdfexport module for the generation on PDF documents. This would allow for other module developers to implement their own solutions.
Conditional report actions icingaweb2-module-reporting#276
Switch back to using syncronous pdf export icingaweb2-module-reporting#275