modal.js: Do not wobble if ESC has been handled otherwise#5512
Merged
Conversation
sukhwinder33445
left a comment
sukhwinder33445
left a comment
Contributor
There was a problem hiding this comment.
This works fine.
I noticed when adding new fields to SearchEditor (without filling them in) and pressing Escape, the modal closes because no input change is detected.
Shouldn't new empty OR deleted fields also count as unsaved changes?
On the other hand, the user may also intentionally want to exit the modal and discard their changes, so the current behavoir is fine.
Member
Author
|
adding empty ones isn't a worthy change in my eyes, removing a condition on the other hand is so you have a point here. But this change is about something else ;) |
sukhwinder33445
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reproduce the prior behavior, open a search editor, request e.g. column suggestions and push ESC.
prior: The modal wobbles
now: Nothing happens