Skip to content

Fix callsites to PdfExportHook assume use of HookEssentials#5526

Merged
lippserd merged 1 commit into
mainfrom
pdfexport-no-hook-essentials
Jun 25, 2026
Merged

Fix callsites to PdfExportHook assume use of HookEssentials#5526
lippserd merged 1 commit into
mainfrom
pdfexport-no-hook-essentials

Conversation

@TheSyscall

Copy link
Copy Markdown
Contributor

#5474 introduced a set of common methods for hooks, #5491 removed these changes to stay compatible with the original implementation, but failed to change back the call sites.

This PR fixes that.

@cla-bot cla-bot Bot added the cla/signed label Jun 25, 2026
@TheSyscall TheSyscall force-pushed the pdfexport-no-hook-essentials branch from bc869e4 to 054b214 Compare June 25, 2026 10:08
@TheSyscall TheSyscall requested a review from Al2Klimov June 25, 2026 10:09
@lippserd lippserd added this to the 2.14.0 milestone Jun 25, 2026
fd6a977 introduced HookEssentials to PdfExport
ea38305 changed the callsites to use HookEssentials
be0a311 reverted the change to PdfExport to stay compatible with the
original implementation but failed to remove the callsites

This commit reverts the changes to the call sites made in ea38305
@TheSyscall TheSyscall force-pushed the pdfexport-no-hook-essentials branch from 054b214 to 7bcc1cd Compare June 25, 2026 11:43
@lippserd lippserd merged commit feeb03d into main Jun 25, 2026
13 checks passed
@lippserd lippserd deleted the pdfexport-no-hook-essentials branch June 25, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants