Skip to content

Fix callsites to PdfExportHook assume use of HookEssentials #5526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lippserd merged 1 commit into from
Jun 25, 2026
Merged

Fix callsites to PdfExportHook assume use of HookEssentials #5526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion library/Icinga/File/Pdf.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
use Dompdf\Dompdf;
use Dompdf\Options;
use Exception;
use Icinga\Application\Hook;
use Icinga\Application\Hook\PdfexportHook;
use Icinga\Application\Icinga;
use Icinga\Exception\ProgrammingError;
Expand Down Expand Up @@ -56,7 +57,7 @@ public function renderControllerAction($controller)

$request = $controller->getRequest();

if (PdfexportHook::isRegistered()) {
if (Hook::has('Pdfexport')) {
$pdfexport = PdfexportHook::first();
$pdfexport->streamPdfFromHtml($html, sprintf(
'%s-%s-%d',
Expand Down
3 changes: 1 addition & 2 deletions library/Icinga/Web/Widget/Tabextension/OutputFormat.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

namespace Icinga\Web\Widget\Tabextension;

use Icinga\Application\Hook\PdfexportHook;
use Icinga\Application\Platform;
use Icinga\Application\Hook;
use Icinga\Web\Url;
Expand Down Expand Up @@ -85,7 +84,7 @@ public function getSupportedTypes()
{
$supportedTypes = array();

$pdfexport = PdfexportHook::isRegistered();
$pdfexport = Hook::has('Pdfexport');

if ($pdfexport || Platform::extensionLoaded('gd')) {
$supportedTypes[self::TYPE_PDF] = array(
Expand Down
Loading