fix: error handling

Author: PascalDR

pymdoccbor/mdoc/issuersigned.py

@@ -3,7 +3,6 @@
 
 from pymdoccbor.mso.verifier import MsoVerifier
 
-
 class IssuerSigned:
     """
     nameSpaces provides the definition within which the data elements of
@@ -22,7 +21,7 @@ class IssuerSigned:
     ]
     """
 
-    def __init__(self, nameSpaces: dict, issuerAuth: Union[dict, bytes]) -> None:
+    def __init__(self, nameSpaces: dict, issuerAuth: Union[cbor2.CBORTag, dict, bytes]) -> None:
         """
         Initialize the IssuerSigned object
 
@@ -32,6 +31,9 @@ def __init__(self, nameSpaces: dict, issuerAuth: Union[dict, bytes]) -> None:
 
         self.namespaces: dict = nameSpaces
 
+        if not issuerAuth:
+            raise ValueError("issuerAuth must be provided")
+
         #  if isinstance(ia, dict):
         self.issuer_auth = MsoVerifier(issuerAuth)
 

pymdoccbor/mdoc/verifier.py

@@ -29,7 +29,14 @@ def __init__(self, docType: str, issuerSigned: dict, deviceSigned: dict = {}) ->
         :param deviceSigned: dict: the deviceSigned info
         """
 
+        if not docType:
+            raise ValueError("You must provide a document type")
+
         self.doctype: str = docType  # eg: 'org.iso.18013.5.1.mDL'
+
+        if not issuerSigned:
+            raise ValueError("You must provide a signed document")
+
         self.issuersigned: List[IssuerSigned] = IssuerSigned(**issuerSigned)
         self.is_valid = False
         self.devicesigned: dict = deviceSigned

pymdoccbor/mso/issuer.py

@@ -73,6 +73,12 @@ def __init__(
                     raise ValueError("private_key must be a dict or CoseKey object")
             else:
                 raise MsoPrivateKeyRequired("MSO Writer requires a valid private key")
+            
+        if not validity:
+            raise ValueError("validity must be present")
+        
+        if not alg:
+            raise ValueError("alg must be present")
 
         self.data: dict = data
         self.hash_map: dict = {}