Skip to content

Commit 557c561

Browse files
committed
Revert "Support additional scopes"
This reverts commit ac5090e.
1 parent 1eab978 commit 557c561

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

src/pyop/provider.py

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -126,9 +126,8 @@ def parse_authentication_request(self, request_body, http_headers=None):
126126

127127
def authorize(self, authentication_request, # type: oic.oic.message.AuthorizationRequest
128128
user_id, # type: str
129-
extra_id_token_claims=None,
129+
extra_id_token_claims=None
130130
# type: Optional[Union[Mapping[str, Union[str, List[str]]], Callable[[str, str], Mapping[str, Union[str, List[str]]]]]
131-
extra_scopes=None,
132131
):
133132
# type: (...) -> oic.oic.message.AuthorizationResponse
134133
"""
@@ -167,11 +166,7 @@ def authorize(self, authentication_request, # type: oic.oic.message.Authorizati
167166
if len(authentication_request['response_type']) == 1:
168167
# only id token is issued -> no way of doing userinfo request, so include all claims in ID Token,
169168
# even those requested by the scope parameter
170-
requested_claims.update(
171-
scope2claims(
172-
authentication_request['scope'], extra_scope_dict=extra_scopes
173-
)
174-
)
169+
requested_claims.update(scope2claims(authentication_request['scope']))
175170

176171
user_claims = self.userinfo.get_claims_for(user_id, requested_claims)
177172
response['id_token'] = self._create_signed_id_token(authentication_request['client_id'], sub,
@@ -345,7 +340,7 @@ def _do_code_exchange(self, request, # type: Dict[str, str]
345340
raise InvalidTokenRequest(str(e), token_request) from e
346341

347342
authentication_request = self.authz_state.get_authorization_request_for_code(token_request['code'])
348-
343+
349344
if token_request['client_id'] != authentication_request['client_id']:
350345
logger.info('Authorization code \'%s\' belonging to \'%s\' was used by \'%s\'',
351346
token_request['code'], authentication_request['client_id'], token_request['client_id'])
@@ -420,7 +415,7 @@ def _verify_client_authentication(self, request_body, http_headers=None):
420415
token_request['client_id'] = verify_client_authentication(self.clients, token_request, http_headers.get('Authorization'))
421416
return token_request
422417

423-
def handle_userinfo_request(self, request=None, http_headers=None, extra_scopes=None):
418+
def handle_userinfo_request(self, request=None, http_headers=None):
424419
# type: (Optional[str], Optional[Mapping[str, str]]) -> oic.oic.message.OpenIDSchema
425420
"""
426421
Handles a userinfo request.
@@ -438,7 +433,7 @@ def handle_userinfo_request(self, request=None, http_headers=None, extra_scopes=
438433
scope = introspection['scope']
439434
user_id = self.authz_state.get_user_id_for_subject_identifier(introspection['sub'])
440435

441-
requested_claims = scope2claims(scope.split(), extra_scope_dict=extra_scopes)
436+
requested_claims = scope2claims(scope.split())
442437
authentication_request = self.authz_state.get_authorization_request_for_access_token(bearer_token)
443438
requested_claims.update(self._get_requested_claims_in(authentication_request, 'userinfo'))
444439
user_claims = self.userinfo.get_claims_for(user_id, requested_claims)

0 commit comments

Comments
 (0)