Skip to content

Commit 6722733

Browse files
committed
swap to the new message instance included in pyop
1 parent cdbdbba commit 6722733

File tree

6 files changed

+15
-16
lines changed

6 files changed

+15
-16
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ user data and OpenID Connect claim names. Hence the underlying data source must
146146
same names as the [standard claims of OpenID Connect](http://openid.net/specs/openid-connect-core-1_0.html#StandardClaims).
147147

148148
```python
149-
from oic.oic.message import AuthorizationRequest
149+
from pyop.message import AuthorizationRequest
150150

151151
from pyop.util import should_fragment_encode
152152

src/pyop/authz_state.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
import uuid
44

55
from oic.extension.message import TokenIntrospectionResponse
6-
from oic.oic.message import AuthorizationRequest
76

7+
from .message import AuthorizationRequest
88
from .access_token import AccessToken
99
from .exceptions import InvalidAccessToken
1010
from .exceptions import InvalidAuthorizationCode
@@ -80,7 +80,7 @@ def __init__(self, subject_identifier_factory, authorization_code_db=None, acces
8080
self.subject_identifiers = subject_identifier_db if subject_identifier_db is not None else {}
8181

8282
def create_authorization_code(self, authorization_request, subject_identifier, scope=None):
83-
# type: (oic.oic.message.AuthorizationRequest, str, Optional[List[str]]) -> str
83+
# type: (AuthorizationRequest, str, Optional[List[str]]) -> str
8484
"""
8585
Creates an authorization code bound to the authorization request and the authenticated user identified
8686
by the subject identifier.
@@ -106,7 +106,7 @@ def create_authorization_code(self, authorization_request, subject_identifier, s
106106
return authorization_code
107107

108108
def create_access_token(self, authorization_request, subject_identifier, scope=None):
109-
# type: (oic.oic.message.AuthorizationRequest, str, Optional[List[str]]) -> se_leg_op.access_token.AccessToken
109+
# type: (AuthorizationRequest, str, Optional[List[str]]) -> se_leg_op.access_token.AccessToken
110110
"""
111111
Creates an access token bound to the authentication request and the authenticated user identified by the
112112
subject identifier.
@@ -315,22 +315,22 @@ def get_user_id_for_subject_identifier(self, subject_identifier):
315315
raise InvalidSubjectIdentifier('{} unknown'.format(subject_identifier))
316316

317317
def get_authorization_request_for_code(self, authorization_code):
318-
# type: (str) -> oic.oic.message.AuthorizationRequest
318+
# type: (str) -> AuthorizationRequest
319319
if authorization_code not in self.authorization_codes:
320320
raise InvalidAuthorizationCode('{} unknown'.format(authorization_code))
321321

322322
return AuthorizationRequest().from_dict(
323323
self.authorization_codes[authorization_code][self.KEY_AUTHORIZATION_REQUEST])
324324

325325
def get_authorization_request_for_access_token(self, access_token_value):
326-
# type: (str) -> oic.oic.message.AuthorizationRequest
326+
# type: (str) ->
327327
if access_token_value not in self.access_tokens:
328328
raise InvalidAccessToken('{} unknown'.format(access_token_value))
329329

330330
return AuthorizationRequest().from_dict(self.access_tokens[access_token_value][self.KEY_AUTHORIZATION_REQUEST])
331331

332332
def get_subject_identifier_for_code(self, authorization_code):
333-
# type: (str) -> oic.oic.message.AuthorizationRequest
333+
# type: (str) -> AuthorizationRequest
334334
if authorization_code not in self.authorization_codes:
335335
raise InvalidAuthorizationCode('{} unknown'.format(authorization_code))
336336

src/pyop/provider.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def __init__(self, signing_key, configuration_information, authz_state, clients,
8383
self.userinfo = userinfo
8484
self.id_token_lifetime = id_token_lifetime
8585

86-
self.authentication_request_validators = [] # type: List[Callable[[oic.oic.message.AuthorizationRequest], Boolean]]
86+
self.authentication_request_validators = [] # type: List[Callable[[AuthorizationRequest], Boolean]]
8787
self.authentication_request_validators.append(authorization_request_verify)
8888
self.authentication_request_validators.append(
8989
functools.partial(client_id_is_known, self))
@@ -116,7 +116,7 @@ def jwks(self):
116116
return {'keys': keys}
117117

118118
def parse_authentication_request(self, request_body, http_headers=None):
119-
# type: (str, Optional[Mapping[str, str]]) -> oic.oic.message.AuthorizationRequest
119+
# type: (str, Optional[Mapping[str, str]]) -> AuthorizationRequest
120120
"""
121121
Parses and verifies an authentication request.
122122
@@ -132,7 +132,7 @@ def parse_authentication_request(self, request_body, http_headers=None):
132132
logger.debug('parsed authentication_request: %s', auth_req)
133133
return auth_req
134134

135-
def authorize(self, authentication_request, # type: oic.oic.message.AuthorizationRequest
135+
def authorize(self, authentication_request, # type: AuthorizationRequest
136136
user_id, # type: str
137137
extra_id_token_claims=None
138138
# type: Optional[Union[Mapping[str, Union[str, List[str]]], Callable[[str, str], Mapping[str, Union[str, List[str]]]]]
@@ -218,7 +218,7 @@ def _create_subject_identifier(self, user_id, client_id, redirect_uri):
218218
return self.authz_state.get_subject_identifier(subject_type, user_id, sector_identifier)
219219

220220
def _get_requested_claims_in(self, authentication_request, response_method):
221-
# type (oic.oic.message.AuthorizationRequest, str) -> Mapping[str, Optional[Mapping[str, Union[str, List[str]]]]
221+
# type (AuthorizationRequest, str) -> Mapping[str, Optional[Mapping[str, Union[str, List[str]]]]
222222
"""
223223
Parses any claims requested using the 'claims' request parameter, see
224224
<a href="http://openid.net/specs/openid-connect-core-1_0.html#ClaimsParameter">
@@ -286,7 +286,7 @@ def _create_signed_id_token(self,
286286
return id_token.to_jwt([self.signing_key], alg)
287287

288288
def _check_subject_identifier_matches_requested(self, authentication_request, sub):
289-
# type (oic.message.AuthorizationRequest, str) -> None
289+
# type (AuthorizationRequest, str) -> None
290290
"""
291291
Verifies the subject identifier against any requested subject identifier using the claims request parameter.
292292
:param authentication_request: authentication request

tests/pyop/test_authz_state.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
from unittest.mock import patch, Mock
55

66
import pytest
7-
from oic.oic.message import AuthorizationRequest
87

8+
from pyop.message import AuthorizationRequest
99
from pyop.authz_state import AccessToken, InvalidScope
1010
from pyop.authz_state import AuthorizationState
1111
from pyop.exceptions import InvalidSubjectIdentifier, InvalidAccessToken, InvalidAuthorizationCode, InvalidRefreshToken

tests/pyop/test_exceptions.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
from urllib.parse import urlparse, parse_qsl
22

3-
from oic.oic.message import AuthorizationRequest
4-
3+
from pyop.message import AuthorizationRequest
54
from pyop.exceptions import InvalidAuthenticationRequest
65

76

tests/pyop/test_util.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import pytest
2-
from oic.oic.message import AuthorizationRequest
32

3+
from pyop.message import AuthorizationRequest
44
from pyop.util import should_fragment_encode
55

66

0 commit comments

Comments
 (0)