From c4f2febfe443cf3493185621b1f26650ffa7f190 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Tue, 20 Aug 2024 14:37:04 +0100 Subject: [PATCH] Prepare for QUnit 3.0 Tweak a few selectors so that the theme is compatible with QUnit 3.0 (currently in alpha). Selectors based on docs at https://qunitjs.com/browser/#theme-api --- .changeset/violet-coats-wink.md | 5 +++ qunit.css | 59 +++++++++++++++------------------ 2 files changed, 32 insertions(+), 32 deletions(-) create mode 100644 .changeset/violet-coats-wink.md diff --git a/.changeset/violet-coats-wink.md b/.changeset/violet-coats-wink.md new file mode 100644 index 0000000..9be62da --- /dev/null +++ b/.changeset/violet-coats-wink.md @@ -0,0 +1,5 @@ +--- +"qunit-theme-ember": minor +--- + +Prepare CSS for QUnit 3.0 compat diff --git a/qunit.css b/qunit.css index 2120a36..9a037dc 100644 --- a/qunit.css +++ b/qunit.css @@ -87,7 +87,8 @@ body { color: var(--color-gray-900); } -#qunit-userAgent { +/* QUnit 2 only */ +#qunit > #qunit-userAgent { background-color: var(--color-gray-100); color: var(--color-gray-900); text-shadow: none; @@ -142,51 +143,52 @@ body { color: var(--color-gray-900); } -#qunit-tests li { +#qunit-tests > li { background-color: var(--color-gray-100); } -#qunit-tests .pass { +#qunit-tests li { + padding-top: var(--spacing-1); + padding-bottom: var(--spacing-1); + border-bottom: 0; +} + +#qunit-tests > li.pass { color: var(--color-gray-900); + background-color: var(--color-success); } -#qunit-tests .pass .test-name { +#qunit-tests > li.pass .test-name { color: var(--color-gray-700); } -#qunit-tests li { - padding-top: var(--spacing-1); - padding-bottom: var(--spacing-1); - border-bottom: 0; +#qunit-tests > li.fail { + background-color: var(--color-danger); } -#qunit-tests li li.pass { - color: var(--color-text-success); - border-left: 10px solid var(--color-green); +#qunit-tests > li.fail .test-expected { + color: var(--color-green); } -#qunit-tests li p.qunit-source { - color: var(--color-gray-900); +#qunit-tests > li.fail .test-actual { + color: var(--color-red); } -ol.qunit-assert-list { +.qunit-assert-list { margin: 10px 0; } -ol.qunit-assert-list .fail { - border-left: 0; +#qunit-tests .qunit-assert-list .pass { + color: var(--color-text-success); + border-left: 10px solid var(--color-green); } -#qunit-tests li li.fail { +#qunit-tests .qunit-assert-list .fail { border-left-color: var(--color-red); } -#qunit-tests .fail .test-expected { - color: var(--color-green); -} - -#qunit-tests .fail .test-actual { - color: var(--color-red); +.qunit-source { + color: var(--color-gray-900); } #qunit-testrunner-toolbar button, @@ -222,14 +224,6 @@ ol.qunit-assert-list .fail { color: var(--color-white); } -#qunit-tests .pass { - background-color: var(--color-success); -} - -#qunit-tests .fail { - background-color: var(--color-danger); -} - #qunit-testrunner-toolbar input[type="text"], #qunit-testrunner-toolbar #qunit-modulefilter-search { border: 1px solid var(--color-gray-300); @@ -250,7 +244,8 @@ ol.qunit-assert-list .fail { border-color: var(--color-gray-300); } -#qunit-modulefilter-search-container:after { +/* QUnit 2 only */ +label[for="qunit-modulefilter-search"] + #qunit-modulefilter-search-container:after { content: ""; width: var(--spacing-2); height: var(--spacing-2);