Skip to content

Make green glow only in calendar#1772

Merged
IgnisDa merged 2 commits into
IgnisDa:mainfrom
dimon222:bugfix/glow_only_calendar
May 22, 2026
Merged

Make green glow only in calendar#1772
IgnisDa merged 2 commits into
IgnisDa:mainfrom
dimon222:bugfix/glow_only_calendar

Conversation

@dimon222
Copy link
Copy Markdown
Contributor

@dimon222 dimon222 commented May 22, 2026

This fixes behavior described in #1770 (comment)
This adds conditionals to only apply it on calendar and nothing else.

Summary by CodeRabbit

  • Bug Fixes
    • Improved watched-state tracking for calendar event metadata so calendar items correctly reflect viewing history.
    • Ensured calendar-specific context is considered when determining and displaying watched/completed status.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 22, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f93920a4-2712-4b70-9fbd-827f2cc4b1c9

📥 Commits

Reviewing files that changed from the base of the PR and between 7a7c45f and da3306b.

📒 Files selected for processing (2)
  • apps/frontend/app/components/media/display-items.tsx
  • apps/frontend/app/routes/_dashboard.calendar.tsx

Walkthrough

This PR adds an optional isCalendarEvent prop to MetadataDisplayItem that gates the watched-state computation; the calendar route now passes isCalendarEvent when rendering calendar event metadata.

Changes

Calendar event watched-state gating

Layer / File(s) Summary
Watched-state gating for calendar events
apps/frontend/app/components/media/display-items.tsx, apps/frontend/app/routes/_dashboard.calendar.tsx
MetadataDisplayItem accepts an optional isCalendarEvent prop. The isCalendarEventWatched computed value now requires props.isCalendarEvent before evaluating completed-history-based watched logic and includes props.isCalendarEvent in the useMemo dependency array. CalendarEventMetadata passes isCalendarEvent={true} when rendering the metadata display item.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • IgnisDa/ryot#1770: Both PRs modify apps/frontend/app/components/media/display-items.tsx's MetadataDisplayItem watched-state logic (isCalendarEventWatched) and its useMemo dependencies, with the main PR gating the computation behind a new isCalendarEvent prop while the retrieved PR expands "watched" determination to additional metadata lots.
  • IgnisDa/ryot#1729: Both PRs touch apps/frontend/app/components/media/display-items.tsx around computing/passing "calendar event watched" state (isCalendarEventWatched), with the main PR adding isCalendarEvent gating while the retrieved PR uses that watched flag to drive calendar styling.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: restricting the green glow effect to only appear in the calendar view, which aligns with the PR's objective to fix glow behavior by adding conditionals.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@IgnisDa IgnisDa merged commit 009b654 into IgnisDa:main May 22, 2026
9 of 10 checks passed
@IgnisDa
Copy link
Copy Markdown
Owner

IgnisDa commented May 22, 2026

Thanks for this!

@dimon222 dimon222 deleted the bugfix/glow_only_calendar branch May 22, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants