Skip to content

Commit 52f5478

Browse files
Copilotkdinev
andauthored
fix: use GlobalPositionStrategy with CloseScrollStrategy in overlay-scroll-2 sample
Agent-Logs-Url: https://github.com/IgniteUI/igniteui-angular-samples/sessions/06c3dd94-b750-43d0-b775-8b1dc58a8503 Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>
1 parent 93767bc commit 52f5478

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

src/app/interactions/overlay/overlay-scroll-2/overlay-scroll-sample-2.component.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Component, ElementRef, OnDestroy, OnInit, ViewChild, ViewContainerRef, inject } from '@angular/core';
2-
import { AbsoluteScrollStrategy, BlockScrollStrategy, CloseScrollStrategy, ConnectedPositioningStrategy, IgxOverlayService, NoOpScrollStrategy } from 'igniteui-angular/core';
2+
import { AbsoluteScrollStrategy, BlockScrollStrategy, CloseScrollStrategy, ConnectedPositioningStrategy, GlobalPositionStrategy, IgxOverlayService, NoOpScrollStrategy } from 'igniteui-angular/core';
33
import { IgxIconComponent } from 'igniteui-angular/icon';
44
import { Subject } from 'rxjs';
55
import { takeUntil } from 'rxjs/operators';
@@ -52,22 +52,26 @@ export class OverlayScrollSample2Component implements OnInit, OnDestroy {
5252

5353
public onClickScrollStrategy(strategy: string) {
5454
let scrollStrategy;
55-
const positionStrategy = new ConnectedPositioningStrategy();
55+
let positionStrategy;
5656
switch (strategy) {
5757
case ('absolute'):
5858
scrollStrategy = new AbsoluteScrollStrategy();
59+
positionStrategy = new ConnectedPositioningStrategy();
5960
this._target = this.scrollDemo.nativeElement.children[0];
6061
break;
6162
case ('block'):
6263
scrollStrategy = new BlockScrollStrategy();
64+
positionStrategy = new ConnectedPositioningStrategy();
6365
this._target = this.scrollDemo.nativeElement.children[1];
6466
break;
6567
case ('close'):
6668
scrollStrategy = new CloseScrollStrategy();
69+
positionStrategy = new GlobalPositionStrategy();
6770
this._target = this.scrollDemo.nativeElement.children[2];
6871
break;
6972
default:
7073
scrollStrategy = new NoOpScrollStrategy();
74+
positionStrategy = new ConnectedPositioningStrategy();
7175
this._target = this.scrollDemo.nativeElement.children[3];
7276
}
7377
if (this._overlayId) {

0 commit comments

Comments
 (0)