Skip to content

Ttonev/fix both side pin sample #3761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkamburov merged 13 commits into from
Jan 22, 2026
Merged

Ttonev/fix both side pin sample #3761

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
14b1889
fix(sample): fix pin buttons to update pin state
tishko0 Oct 27, 2025
3c826f8
Merge pull request #3795 from IgniteUI/vnext
ChronosSF Nov 26, 2025
c5d0585
Merge pull request #3838 from IgniteUI/vnext
ChronosSF Dec 3, 2025
4d5b972
Merge pull request #3841 from IgniteUI/vnext
ChronosSF Dec 4, 2025
ec79aae
Merge branch 'vnext' into ttonev/fix-both-side-pin-sample
tishko0 Dec 19, 2025
d1a05a0
fix(lob): import IgxCategoryChartModule instead of core
ddaribo Jan 13, 2026
a7dd135
Merge pull request #3867 from IgniteUI/bpachilova/fix-grid-master-det…
ChronosSF Jan 14, 2026
6904863
refactor(sample): Changed pin methods to use api instead
tishko0 Jan 20, 2026
1b0b18d
Merge branch 'vnext', remote-tracking branch 'origin' into ttonev/fix…
tishko0 Jan 20, 2026
08bcf16
Merge branch 'ttonev/fix-both-side-pin-sample' of https://github.com/…
tishko0 Jan 20, 2026
963563e
chore(both-side-pin): add data for Region field
Jan 22, 2026
b86582e
fix(sample): added pining via pai for hgrid & tgrid
tishko0 Jan 22, 2026
92f8707
Merge branch 'ttonev/fix-both-side-pin-sample' of https://github.com/…
tishko0 Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/app/grid/grid-sample-pinning-both-sides/grid-toolbar-pinning-both-sides.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,14 @@ export class GridBothSideToolbarPinningSampleComponent implements OnInit {

public pinLeft() {
this.grid1.selectedColumns().forEach((col: IgxColumnComponent) => {
col.pinned = false;

@MayaKirova MayaKirova Jan 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could just use the api instead of changing the props. The column has pin method API.

@dkamburov dkamburov Jan 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tishko0

col.pinningPosition = ColumnPinningPosition.Start;
col.pinned = true;
});
}
public pinRight() {
this.grid1.selectedColumns().forEach((col: IgxColumnComponent) => {
col.pinned = false;
col.pinningPosition = ColumnPinningPosition.End;
col.pinned = true;
});
Expand Down
2 changes: 2 additions & 0 deletions ...archical-grid-sample-both-sides-pinning/hierarchical-grid-both-sides-pinning.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,15 @@ export class HierarchicalGridBothSidePinningSampleComponent implements OnInit {

public pinLeft() {
this.grid1.selectedColumns().forEach((col: IgxColumnComponent) => {
col.pinned = false;

@MayaKirova MayaKirova Jan 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here pls

col.pinningPosition = ColumnPinningPosition.Start;
col.pinned = true;
});
}

public pinRight() {
this.grid1.selectedColumns().forEach((col: IgxColumnComponent) => {
col.pinned = false;
col.pinningPosition = ColumnPinningPosition.End;
col.pinned = true;
});
Expand Down
2 changes: 2 additions & 0 deletions src/app/tree-grid/tree-grid-sample-both-pinning/tree-grid-both-sides-pinning.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,15 @@ export class TreeGridBothSidesPinningSampleComponent implements OnInit {

public pinLeft() {
this.grid1.selectedColumns().forEach((col: IgxColumnComponent) => {
col.pinned = false;

@MayaKirova MayaKirova Jan 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here pls

col.pinningPosition = ColumnPinningPosition.Start;
col.pinned = true;
});
}

public pinRight() {
this.grid1.selectedColumns().forEach((col: IgxColumnComponent) => {
col.pinned = false;
col.pinningPosition = ColumnPinningPosition.End;
col.pinned = true;
});
Expand Down