Skip to content

Commit 0bffac0

Browse files
committed
feat(overlay): remove outlet from column moving
1 parent a84a7d7 commit 0bffac0

File tree

9 files changed

+13
-4
lines changed

9 files changed

+13
-4
lines changed

projects/igniteui-angular/expansion-panel/src/expansion-panel/expansion-panel.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1189,7 +1189,7 @@ describe('igxExpansionPanel', () => {
11891189
expect(grid.attributes.getNamedItem('role').nodeValue).toEqual('grid');
11901190
expect(grid.attributes.getNamedItem('id').nodeValue).toEqual(fixture.componentInstance.grid1.id);
11911191
expect(grid.attributes.getNamedItem('tabindex').nodeValue).toEqual('0');
1192-
expect(grid.childElementCount).toEqual(6);
1192+
expect(grid.childElementCount).toEqual(7);
11931193
}));
11941194
it('Should apply all appropriate classes on combo initialization_image + text content', fakeAsync(() => {
11951195
const fixture: ComponentFixture<IgxExpansionPanelImageComponent> = TestBed.createComponent(IgxExpansionPanelImageComponent);

projects/igniteui-angular/grids/core/src/common/grid.interface.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -657,6 +657,7 @@ export interface GridType extends IGridDataBindable {
657657
expansionStates: Map<any, boolean>;
658658
parentVirtDir: any;
659659
tbody: any;
660+
dragGhostHost: ElementRef<HTMLElement>;
660661
verticalScrollContainer: any;
661662
dataRowList: any;
662663
rowList: any;

projects/igniteui-angular/grids/core/src/headers/grid-header-group.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
'igx-grid-th--selected': selected,
5959
'igx-grid-th--active': activeGroup}"
6060
[igxColumnMovingDrag]="column"
61-
[ghostHost]="grid.outlet.nativeElement"
61+
[ghostHost]="grid.dragGhostHost.nativeElement"
6262
[attr.droppable]="true"
6363
[igxColumnMovingDrop]="column"
6464
(pointerdown)="pointerdown($event)"
@@ -108,7 +108,7 @@
108108
[ngClass]="column.headerClasses"
109109
[ngStyle]="column.headerStyles | igxHeaderGroupStyle:column:grid.pipeTrigger"
110110
[igxColumnMovingDrag]="column"
111-
[ghostHost]="grid.outlet.nativeElement"
111+
[ghostHost]="grid.dragGhostHost.nativeElement"
112112
[attr.droppable]="true"
113113
(pointerdown)="activate()"
114114
[style.width]="column.resolvedWidth"

projects/igniteui-angular/grids/grid/src/grid-base.directive.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1316,6 +1316,10 @@ export abstract class IgxGridBaseDirective implements GridType,
13161316
@ViewChild('tbody', { static: true })
13171317
public tbody: ElementRef;
13181318

1319+
/** @hidden @internal */
1320+
@ViewChild('igxDragGhostHost', { read: ElementRef, static: true })
1321+
public dragGhostHost: ElementRef<HTMLElement>;
1322+
13191323
/** @hidden @internal */
13201324
@ViewChild("bodyViewContainerRef", { read: ViewContainerRef, static: true })
13211325
public bodyViewContainerRef?: ViewContainerRef;

projects/igniteui-angular/grids/grid/src/grid.component.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -319,6 +319,7 @@
319319
<igx-grid-column-resizer></igx-grid-column-resizer>
320320
}
321321
<div class="igx-grid__outlet" #igxFilteringOverlayOutlet igxOverlayOutlet></div>
322+
<div class="igx-grid__outlet" #igxDragGhostHost></div>
322323
@if (platform.isElements) {
323324
<div #sink style="display: none;"></div>
324325
<ng-content select="igx-grid-state,igc-grid-state"></ng-content>

projects/igniteui-angular/grids/hierarchical-grid/src/hierarchical-grid.component.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,7 @@
272272
}
273273
<div class="igx-grid__loading-outlet" #igxLoadingOverlayOutlet></div>
274274
<div class="igx-grid__outlet" #igxFilteringOverlayOutlet igxOverlayOutlet></div>
275+
<div class="igx-grid__outlet" #igxDragGhostHost></div>
275276
@if (platform.isElements) {
276277
<div #sink style="display: none;"></div>
277278
<ng-content select="igx-grid-state,igc-grid-state"></ng-content>

projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.component.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,7 @@
125125
}
126126
<div class="igx-grid__loading-outlet" #igxLoadingOverlayOutlet></div>
127127
<div class="igx-grid__outlet" #igxFilteringOverlayOutlet igxOverlayOutlet></div>
128+
<div class="igx-grid__outlet" #igxDragGhostHost></div>
128129

129130
<ng-template #headerTemplate let-column>
130131
<div class="igx-grid__tr--header">

projects/igniteui-angular/grids/pivot-grid/src/pivot-row-dimension-header-group.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
[ngClass]="column.headerClasses"
2121
[ngStyle]="column.headerStyles | igxHeaderGroupStyle:column:grid.pipeTrigger"
2222
[igxColumnMovingDrag]="column"
23-
[ghostHost]="grid.outlet.nativeElement"
23+
[ghostHost]="grid.dragGhostHost.nativeElement"
2424
[attr.droppable]="true"
2525
(pointerdown)="pointerdown($event)"
2626
[igxColumnMovingDrop]="column"

projects/igniteui-angular/grids/tree-grid/src/tree-grid.component.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,7 @@
252252
}
253253
<div class="igx-grid__loading-outlet" #igxLoadingOverlayOutlet></div>
254254
<div class="igx-grid__outlet" #igxFilteringOverlayOutlet igxOverlayOutlet></div>
255+
<div class="igx-grid__outlet" #igxDragGhostHost></div>
255256
@if (platform.isElements) {
256257
<div #sink style="display: none;"></div>
257258
<ng-content select="igx-grid-state,igc-grid-state"></ng-content>

0 commit comments

Comments
 (0)