Merge branch 'master' into dpetev/control-flow-test-track-leftovers

Author: ChronosSF

.github/workflows/codeql-analysis.yml

@@ -13,10 +13,10 @@ name: "CodeQL"
 
 on:
   push:
-    branches: [ master, 19.0.x, 18.2.x, 17.2.x, 16.1.x, 15.1.x ]
+    branches: [ master, 19.1.x, 18.2.x, 17.2.x, 16.1.x, 15.1.x ]
   pull_request:
     # The branches below must be a subset of the branches above
-    branches: [ master, 19.0.x, 18.2.x, 17.2.x, 16.1.x, 15.1.x ]
+    branches: [ master, 19.1.x, 18.2.x, 17.2.x, 16.1.x, 15.1.x ]
   schedule:
     - cron: '33 4 * * 4'
 

.vscode/settings.json

@@ -3,7 +3,13 @@
     "javascript.preferences.quoteStyle": "single",
     "typescript.preferences.quoteStyle": "single",
     "cSpell.words": [
+        "aria-describedby",
+        "aria-haspopup",
+        "aria-labelledby",
         "ghostclass",
+        "groupable",
+        "groupby",
+        "maxlength",
         "ungroup"
     ]
-}
+}

SECURITY.md

@@ -4,7 +4,8 @@
 
 | Version  | Supported          |
 | -------- | ------------------ |
-| 19.0.x   | :white_check_mark: |
+| 19.1.x   | :white_check_mark: |
+| 19.0.x   | :x:                |
 | 18.2.x   | :white_check_mark: |
 | 18.1.x   | :x:                |
 | 18.0.x   | :x:                |

projects/igniteui-angular/src/lib/drop-down/drop-down.component.spec.ts

@@ -926,7 +926,7 @@ describe('IgxDropDown ', () => {
             });
         });
     });
-    describe('Virtualisation tests', () => {
+    describe('Virtualization tests', () => {
         let scroll: IgxForOfDirective<any>;
         let items;
         configureTestSuite();

projects/igniteui-angular/src/lib/grids/filtering/excel-style/excel-style-filtering.component.ts

@@ -549,7 +549,7 @@ export class IgxGridExcelStyleFilteringComponent extends BaseFilteringComponent
         const lowerCaseFilterValues = new Set(Array.from(expr.expression.searchVal).map((value: string) => value.toLowerCase()));
 
         this.grid.data.forEach(item => {
-            if (lowerCaseFilterValues.has(item[this.column.field]?.toLowerCase())) {
+            if (typeof item[this.column.field] === "string" && lowerCaseFilterValues.has(item[this.column.field]?.toLowerCase())) {
                 expr.expression.searchVal.add(item[this.column.field]);
             }
         });

projects/igniteui-angular/src/lib/grids/grid/grid-cell-editing.spec.ts

@@ -18,7 +18,7 @@ import { Subject, fromEvent } from 'rxjs';
 import { SortingDirection } from '../../data-operations/sorting-strategy';
 import { IGridEditDoneEventArgs, IGridEditEventArgs, IgxColumnComponent } from '../public_api';
 
-const DEBOUNCETIME = 30;
+const DEBOUNCE_TIME = 30;
 const CELL_CSS_CLASS = '.igx-grid__td';
 const CELL_CSS_CLASS_NUMBER_FORMAT = '.igx-grid__td--number';
 const CELL_CLASS_IN_EDIT_MODE = 'igx-grid__td--editing';
@@ -469,7 +469,7 @@ describe('IgxGrid - Cell Editing #grid', () => {
 
             UIInteractions.triggerKeyDownEvtUponElem('ArrowDown', inputElem, true);
             fixture.detectChanges();
-            await wait(DEBOUNCETIME);
+            await wait(DEBOUNCE_TIME);
 
             inputElem = document.activeElement as HTMLInputElement;
             expect(cell.editMode).toBeTruthy();
@@ -499,7 +499,7 @@ describe('IgxGrid - Cell Editing #grid', () => {
 
             UIInteractions.triggerKeyDownEvtUponElem('ArrowUp', inputElem, true);
             fixture.detectChanges();
-            await wait(DEBOUNCETIME);
+            await wait(DEBOUNCE_TIME);
 
             inputElem = document.activeElement as HTMLInputElement;
             expect(cell.editMode).toBeTruthy();
@@ -524,7 +524,7 @@ describe('IgxGrid - Cell Editing #grid', () => {
 
             UIInteractions.triggerKeyDownEvtUponElem('arrowright', inputElem, true);
             fixture.detectChanges();
-            await wait(DEBOUNCETIME);
+            await wait(DEBOUNCE_TIME);
 
             const displayContainer = parseInt(virtRow.dc.instance._viewContainer.element.nativeElement.style.left, 10);
             expect(cell.editMode).toBeTruthy();
@@ -551,7 +551,7 @@ describe('IgxGrid - Cell Editing #grid', () => {
             expect(cellElem.classList.contains(CELL_CLASS_IN_EDIT_MODE)).toBe(true);
             const virtRowStyle = parseInt(virtRow.dc.instance._viewContainer.element.nativeElement.style.left, 10);
             UIInteractions.triggerKeyDownEvtUponElem('ArrowLeft', inputElem, fixture);
-            await wait(DEBOUNCETIME);
+            await wait(DEBOUNCE_TIME);
             fixture.detectChanges();
 
             inputElem = document.activeElement as HTMLInputElement;

projects/igniteui-angular/src/lib/grids/grid/grid-collapsible-columns.spec.ts

@@ -352,7 +352,7 @@ describe('IgxGrid - multi-column headers #grid', () => {
 
             GridFunctions.verifyGroupIsExpanded(fixture, secondGroup);
 
-            GridFunctions.verifyColumnIsHidden(grid.getColumnByName('PostlCode'), false, 6);
+            GridFunctions.verifyColumnIsHidden(grid.getColumnByName('PostalCode'), false, 6);
 
             // delete another column
             fixture.componentInstance.columnGroups[1].columns = fixture.componentInstance.columnGroups[1].columns.splice(2);

projects/igniteui-angular/src/lib/grids/grid/grid-filtering-advanced.spec.ts

@@ -41,7 +41,7 @@ describe('IgxGrid - Advanced Filtering #grid - ', () => {
             ]
         });
     }));
-    
+
     describe('General tests - ', () => {
         let fix: ComponentFixture<IgxGridAdvancedFilteringComponent>;
         let grid: IgxGridComponent;
@@ -434,13 +434,13 @@ describe('IgxGrid - Advanced Filtering #grid - ', () => {
             grid.openAdvancedFilteringDialog();
             fix.detectChanges();
 
-            // Verfiy there is a root group with 'And' operator line and 2 children.
+            // Verify there is a root group with 'And' operator line and 2 children.
             const rootGroup = QueryBuilderFunctions.getQueryBuilderTreeRootGroup(fix);
             expect(rootGroup).not.toBeNull();
             QueryBuilderFunctions.verifyOperatorLine(QueryBuilderFunctions.getQueryBuilderTreeRootGroupOperatorLine(fix) as HTMLElement, 'and');
             expect(QueryBuilderFunctions.getQueryBuilderTreeChildItems(rootGroup as HTMLElement).length).toBe(2);
 
-            // Verify the contnet of the first child (expression) of the root group.
+            // Verify the content of the first child (expression) of the root group.
             QueryBuilderFunctions.verifyExpressionChipContent(fix, [1], 'Downloads', 'Greater Than', '100');
 
             // Verify the content of the second child (group) of the root group.
@@ -1225,11 +1225,11 @@ describe('IgxGrid - Advanced Filtering #grid - ', () => {
             tick(100);
             fix.detectChanges();
 
-            
+
             // Populate edit inputs.
             QueryBuilderFunctions.selectColumnInEditModeExpression(fix, 1); // Select 'ProductName' column.
             QueryBuilderFunctions.selectOperatorInEditModeExpression(fix, 0); // Select 'Contains' operator.
-            
+
             let input = QueryBuilderFunctions.getQueryBuilderValueInput(fix).querySelector('input');
             UIInteractions.clickAndSendInputElementValue(input, 'angular', fix); // Type filter value.
             // Commit the populated expression.
@@ -1278,7 +1278,7 @@ describe('IgxGrid - Advanced Filtering #grid - ', () => {
             grid = fix.componentInstance.grid;
             fix.detectChanges();
         }));
-        
+
         it('Should allow hosting Advanced Filtering dialog outside of the grid.', fakeAsync(() => {
             // Add a root 'and' group.
             QueryBuilderFunctions.clickQueryBuilderInitialAddConditionBtn(fix, 0);