Skip to content

Commit 838eab6

Browse files
committed
feat(overlay): remove outlet from query builder tree
1 parent 4d1292d commit 838eab6

3 files changed

Lines changed: 4 additions & 35 deletions

File tree

projects/igniteui-angular/grids/core/src/filtering/advanced-filtering/advanced-filtering-dialog.component.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Component, Input, ViewChild, ChangeDetectorRef, AfterViewInit, OnDestroy, HostBinding, inject } from '@angular/core';
1+
import { Component, Input, ViewChild, ChangeDetectorRef, OnDestroy, HostBinding, inject } from '@angular/core';
22
import { Subject } from 'rxjs';
33
import { IActiveNode } from '../../grid-navigation.service';
44
import { GridType } from '../../common/grid.interface';
@@ -34,7 +34,7 @@ import {
3434
templateUrl: './advanced-filtering-dialog.component.html',
3535
imports: [IgxDragDirective, NgClass, IgxQueryBuilderComponent, IgxQueryBuilderHeaderComponent, IgxDragHandleDirective, IgxButtonDirective]
3636
})
37-
export class IgxAdvancedFilteringDialogComponent implements AfterViewInit, OnDestroy {
37+
export class IgxAdvancedFilteringDialogComponent implements OnDestroy {
3838
public cdr = inject(ChangeDetectorRef);
3939
protected platform = inject(PlatformUtil);
4040

@@ -75,12 +75,6 @@ export class IgxAdvancedFilteringDialogComponent implements AfterViewInit, OnDes
7575
this.assignResourceStrings(false);
7676
}, this);
7777
}
78-
/**
79-
* @hidden @internal
80-
*/
81-
public ngAfterViewInit(): void {
82-
this.queryBuilder.setPickerOutlet(this.grid.outlet);
83-
}
8478

8579
/**
8680
* @hidden @internal

projects/igniteui-angular/query-builder/src/query-builder/query-builder-tree.component.ts

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,7 @@ import {
3939
DEFAULT_LOCALE,
4040
onResourceChangeHandle,
4141
IgxDateFormatterPipe,
42-
isTree,
43-
IgxOverlayOutletDirective
42+
isTree
4443
} from 'igniteui-angular/core';
4544
import { IgxDatePickerComponent } from 'igniteui-angular/date-picker';
4645

@@ -401,11 +400,6 @@ export class IgxQueryBuilderTreeComponent implements AfterViewInit, OnDestroy {
401400
*/
402401
public searchValue: { value: any } = { value: null };
403402

404-
/**
405-
* @hidden @internal
406-
*/
407-
public pickerOutlet: IgxOverlayOutletDirective | ElementRef;
408-
409403
/**
410404
* @hidden @internal
411405
*/
@@ -716,15 +710,6 @@ export class IgxQueryBuilderTreeComponent implements AfterViewInit, OnDestroy {
716710
return this._selectedField;
717711
}
718712

719-
/**
720-
* @hidden @internal
721-
*
722-
* used by the grid
723-
*/
724-
public setPickerOutlet(outlet?: IgxOverlayOutletDirective | ElementRef) {
725-
this.pickerOutlet = outlet;
726-
}
727-
728713
/**
729714
* @hidden @internal
730715
*

projects/igniteui-angular/query-builder/src/query-builder/query-builder.component.ts

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { booleanAttribute, ContentChild, EventEmitter, Output, TemplateRef, inject, ContentChildren, QueryList } from '@angular/core';
22
import {
3-
Component, Input, ViewChild, ElementRef, OnDestroy, HostBinding
3+
Component, Input, ViewChild, OnDestroy, HostBinding
44
} from '@angular/core';
55
import { Subject } from 'rxjs';
66
import {
@@ -10,7 +10,6 @@ import {
1010
IQueryBuilderResourceStrings,
1111
QueryBuilderResourceStringsEN,
1212
recreateTree,
13-
IgxOverlayOutletDirective,
1413
getCurrentResourceStrings,
1514
onResourceChangeHandle
1615
} from 'igniteui-angular/core';
@@ -291,15 +290,6 @@ export class IgxQueryBuilderComponent implements OnDestroy {
291290
this.destroy$.complete();
292291
}
293292

294-
/**
295-
* @hidden @internal
296-
*
297-
* used by the grid
298-
*/
299-
public setPickerOutlet(outlet?: IgxOverlayOutletDirective | ElementRef) {
300-
this.queryTree.setPickerOutlet(outlet);
301-
}
302-
303293
/**
304294
* @hidden @internal
305295
*

0 commit comments

Comments
 (0)