Skip to content

Commit 975ec1f

Browse files
committed
chore(overlay): address PR comments
1 parent 838eab6 commit 975ec1f

7 files changed

Lines changed: 24 additions & 10 deletions

File tree

projects/igniteui-angular/date-picker/src/date-picker/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ The date picker also supports binding through `ngModel` if two-way date-bind is
113113
| `overlaySettings` | Changes the default overlay settings used by the `IgxDatePickerComponent`. | OverlaySettings |
114114
| `placeholder` | Sets the placeholder text for empty input. | string |
115115
| `disabled` | Disables or enables the picker. | boolean |
116+
| `outlet` | **Deprecated.** The container used for the pop up element. | IgxOverlayOutletDirective \| ElementRef |
116117
| `type` | Determines how the picker will be styled. | IgxInputGroupType |
117118
| `spinLoop` | Determines if the currently spun date segment should loop over. | boolean |
118119
| `spinDelta` | Delta values used to increment or decrement each editor date part on spin actions. All values default to `1`. | DatePartDeltas |

projects/igniteui-angular/date-picker/src/date-picker/picker-base.directive.ts

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,24 @@ export abstract class PickerBaseDirective implements IToggleView, EditorProvider
185185
this._weekStart = value;
186186
}
187187

188+
/**
189+
* The container used for the pop-up element.
190+
*
191+
* @example
192+
* ```html
193+
* <div igxOverlayOutlet #outlet="overlay-outlet"></div>
194+
* <!-- ... -->
195+
* <igx-date-picker [outlet]="outlet"></igx-date-picker>
196+
* <!-- ... -->
197+
* ```
198+
*
199+
* @deprecated in version 21.2.0. Overlays now use the HTML Popover API and no longer move to the document
200+
* body by default, so using outlet is also no longer needed - just define the overlay in the intended
201+
* DOM tree position instead.
202+
*/
203+
@Input()
204+
public outlet: IgxOverlayOutletDirective | ElementRef;
205+
188206
/**
189207
* Determines how the picker's input will be styled.
190208
*

projects/igniteui-angular/date-picker/src/date-range-picker/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ With projected inputs:
116116
| mode | PickerInteractionMode | Sets whether `IgxDateRangePickerComponent` is in dialog or dropdown mode. Default is `dialog` |
117117
| minValue | Date \| string | The minimum value in a valid range. |
118118
| maxValue | Date \| string | The maximum value in a valid range. |
119+
| outlet | IgxOverlayOutletDirective \| ElementRef<any> | **Deprecated** Gets/Sets the container used for the popup element
119120
| overlaySettings | OverlaySettings | Changes the default overlay settings used by the `IgxDateRangePickerComponent`. |
120121
| placeholder | string | Sets the `placeholder` for single-input `IgxDateRangePickerComponent`. |
121122
| weekStart | number | Sets the start day of the week. Can be assigned to a numeric value or to `WEEKDAYS` enum value. |

projects/igniteui-angular/grids/grid/src/grid.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@
177177
</div>
178178

179179
<div class="igx-grid__loading-outlet">
180-
<div igxToggle>
180+
<div igxToggle #loadingOverlay>
181181
@if (shouldOverlayLoading) {
182182
<igx-circular-bar [indeterminate]="true"></igx-circular-bar>
183183
}

projects/igniteui-angular/grids/hierarchical-grid/src/hierarchical-grid.component.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,7 @@
131131
</div>
132132
<div igxToggle #loadingOverlay>
133133
@if (shouldOverlayLoading) {
134-
<igx-circular-bar [indeterminate]="true">
135-
</igx-circular-bar>
134+
<igx-circular-bar [indeterminate]="true"></igx-circular-bar>
136135
}
137136
</div>
138137
@if (moving && columnInDrag) {
@@ -270,7 +269,6 @@
270269
@if (colResizingService.showResizer) {
271270
<igx-grid-column-resizer></igx-grid-column-resizer>
272271
}
273-
<div class="igx-grid__loading-outlet" #igxLoadingOverlayOutlet></div>
274272
<div class="igx-grid__outlet" #igxFilteringOverlayOutlet igxOverlayOutlet></div>
275273
<div class="igx-grid__outlet" #igxDragGhostHost></div>
276274
@if (platform.isElements) {

projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.component.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,7 @@
6565
</div>
6666
<div igxToggle #loadingOverlay>
6767
@if (shouldOverlayLoading) {
68-
<igx-circular-bar [indeterminate]="true">
69-
</igx-circular-bar>
68+
<igx-circular-bar [indeterminate]="true"></igx-circular-bar>
7069
}
7170
</div>
7271
@if (hasMovableColumns && columnInDrag) {
@@ -123,7 +122,6 @@
123122
@if (colResizingService.showResizer) {
124123
<igx-pivot-grid-column-resizer [restrictResizerTop]="calculateResizerTop()"></igx-pivot-grid-column-resizer>
125124
}
126-
<div class="igx-grid__loading-outlet" #igxLoadingOverlayOutlet></div>
127125
<div class="igx-grid__outlet" #igxFilteringOverlayOutlet igxOverlayOutlet></div>
128126
<div class="igx-grid__outlet" #igxDragGhostHost></div>
129127

projects/igniteui-angular/grids/tree-grid/src/tree-grid.component.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,7 @@
121121
</div>
122122
<div igxToggle #loadingOverlay>
123123
@if (shouldOverlayLoading) {
124-
<igx-circular-bar [indeterminate]="true">
125-
</igx-circular-bar>
124+
<igx-circular-bar [indeterminate]="true"></igx-circular-bar>
126125
}
127126
</div>
128127
@if (moving && columnInDrag) {
@@ -250,7 +249,6 @@
250249
@if (colResizingService.showResizer) {
251250
<igx-grid-column-resizer></igx-grid-column-resizer>
252251
}
253-
<div class="igx-grid__loading-outlet" #igxLoadingOverlayOutlet></div>
254252
<div class="igx-grid__outlet" #igxFilteringOverlayOutlet igxOverlayOutlet></div>
255253
<div class="igx-grid__outlet" #igxDragGhostHost></div>
256254
@if (platform.isElements) {

0 commit comments

Comments
 (0)