Merge pull request #17116 from IgniteUI/coverage-extras

test(extras): adding more coverage

Author: kdinev

package-lock.json

@@ -7,7 +7,7 @@
     "start:elements": "ng serve --project igniteui-angular-elements",
     "start:performance": "ng serve --project igniteui-angular-performance",
     "build": "npm run build:lib && npm run build:elements && npm run build:extras && npm run build:schematics && npm run build:migrations && npm run build:i18n",
-    "test": "ng test igniteui-angular",
+    "test": "npm run test:lib && npm run test:styles && npm run test:schematics && npm run test:i18n && npm run test:extras && npm run test:elements",
     "lint": "ng lint",
     "e2e": "ng e2e",
     "test:lib": "ng test igniteui-angular --watch=false --no-progress --code-coverage",

package.json

@@ -0,0 +1,58 @@
+# See http://help.github.com/ignore-files/ for more about ignoring files.
+
+
+# compiled output
+/dist
+/tmp
+/out-tsc
+
+.angular/*
+
+# dependencies
+/node_modules
+
+# IDEs and editors
+/.idea
+.project
+.classpath
+.c9/
+*.launch
+.settings/
+*.sublime-workspace
+
+# IDE - VSCode/VS
+.vscode/*
+.vs/*
+!.vscode/settings.json
+!.vscode/tasks.json
+!.vscode/launch.json
+!.vscode/extensions.json
+
+# misc
+/.angular/cache
+/.sass-cache
+/connect.lock
+/coverage
+/libpeerconnection.log
+npm-debug.log
+yarn-error.log
+testem.log
+/typings
+TESTS-**.xml
+
+# System Files
+.DS_Store
+Thumbs.db
+
+src/**/*.js
+src/**/*.js.map
+src/**/*.css.map
+
+# Typedoc and SassDoc Themes
+extras/sassdoc/**/*
+extras/docs/themes/typedoc/bin
+extras/docs/themes/sassdoc/node_modules
+extras/docs/themes/sassdoc/sassdoc/*
+
+# Localization sources
+i18nRepo

projects/igniteui-angular-extras/.gitignore

@@ -140,4 +140,96 @@ describe('IgxChartMenuComponent', () => {
             expect(component.isConfigAreaExpanded).toBeFalse();
         });
     });
+
+    describe('ngAfterViewInit', () => {
+        it('should create a ResizeObserver and call createChart when currentChartType and chartDirective are set', () => {
+            const factorySpy = jasmine.createSpy('chartFactory');
+            component.chartDirective = { chartFactory: factorySpy };
+            component.chartArea = { clear: () => {} } as any;
+            component.currentChartType = 'Pie';
+
+            component.ngAfterViewInit();
+
+            expect(factorySpy).toHaveBeenCalledWith('Pie', component.chartArea);
+        });
+
+        it('should not call createChart when currentChartType is not set', () => {
+            const factorySpy = jasmine.createSpy('chartFactory');
+            component.chartDirective = { chartFactory: factorySpy };
+            component.chartArea = { clear: () => {} } as any;
+            component.currentChartType = undefined;
+
+            component.ngAfterViewInit();
+
+            expect(factorySpy).not.toHaveBeenCalled();
+        });
+
+        it('should not call createChart when chartDirective is not set', () => {
+            component.chartDirective = undefined;
+            component.currentChartType = 'Pie';
+
+            expect(() => component.ngAfterViewInit()).not.toThrow();
+        });
+    });
+
+    describe('ngOnDestroy', () => {
+        it('should disconnect the contentObserver if it exists', () => {
+            component.ngAfterViewInit();
+            const observer = (component as any).contentObserver;
+            const disconnectSpy = spyOn(observer, 'disconnect');
+
+            component.ngOnDestroy();
+
+            expect(disconnectSpy).toHaveBeenCalled();
+        });
+
+        it('should complete the chartDialogResizeNotify subject', () => {
+            const completeSpy = spyOn(component.chartDialogResizeNotify, 'complete');
+
+            component.ngOnDestroy();
+
+            expect(completeSpy).toHaveBeenCalled();
+        });
+
+        it('should not throw when contentObserver is not set', () => {
+            (component as any).contentObserver = undefined;
+
+            expect(() => component.ngOnDestroy()).not.toThrow();
+        });
+    });
+
+    describe('createChart title formatting', () => {
+        beforeEach(() => {
+            component.chartDirective = { chartFactory: () => {} };
+            component.chartArea = { clear: () => {} } as any;
+        });
+
+        it('should replace only the first comma with a space for two-word types', () => {
+            component.createChart('ColumnGrouped');
+            expect(component.title).toBe('Column Grouped');
+        });
+
+        it('should handle chart types with numbers like Column100Stacked', () => {
+            component.createChart('Column100Stacked');
+            // split on uppercase: 'Column100','Stacked' → 'Column100 Stacked'
+            expect(component.title).toBe('Column100 Stacked');
+        });
+
+        it('should handle single-word chart types', () => {
+            component.createChart('Pie');
+            expect(component.title).toBe('Pie');
+        });
+
+        it('should handle three-word chart types like ScatterBubbleChart', () => {
+            component.createChart('ScatterBubbleChart');
+            // 'Scatter,Bubble,Chart'.replace(',', ' ') → 'Scatter Bubble,Chart'
+            expect(component.title).toBe('Scatter Bubble,Chart');
+        });
+    });
+
+    describe('images', () => {
+        it('should initialize images from charts module', () => {
+            expect(component.images).toBeDefined();
+        });
+    });
 });

projects/igniteui-angular-extras/src/lib/context-menu/chart-dialog/chart-dialog.component.spec.ts

@@ -4,6 +4,7 @@ import { Subject } from 'rxjs';
 import { IgxOverlayService } from 'igniteui-angular/core';
 import { IgxContextMenuComponent } from './context-menu.component';
 import { CHART_TYPE } from '../directives/chart-integration/chart-types';
+import { IgxChartMenuComponent } from 'igniteui-angular-extras';
 
 describe('IgxContextMenuComponent', () => {
     let component: IgxContextMenuComponent;
@@ -265,4 +266,68 @@ describe('IgxContextMenuComponent', () => {
             expect(component.displayCreationTab).toBeFalse();
         });
     });
+
+    describe('ngOnDestroy', () => {
+        it('should complete destroy$ and not throw on subsequent event emissions', () => {
+            component.ngOnDestroy();
+
+            // After destroy, emitting on subscribed observables should not cause errors
+            expect(() => mockContextDirective.chartsDirective.chartTypesDetermined.emit({ chartsForCreation: [] })).not.toThrow();
+            expect(() => mockContextDirective.textFormatter.formattersReady.emit([])).not.toThrow();
+            expect(() => mockContextDirective.buttonClose.emit()).not.toThrow();
+        });
+    });
+
+    describe('overlayService.closing subscription', () => {
+        it('should not reopen tabsMenu when closing a dialog that is not IgxChartMenuComponent', () => {
+            // Simulate having an open dialog
+            (component as any)._dialogId = 'dialog-id';
+            const mockInstance = new (class { })();
+            Object.setPrototypeOf(mockInstance, { constructor: { name: 'IgxChartMenuComponent' } });
+
+            // The closing event checks instanceof IgxChartMenuComponent — we mock at the overlay level
+            (mockOverlay.closing as Subject<any>).next({
+                componentRef: { instance: TestBed.createComponent(IgxChartMenuComponent).componentInstance }
+            });
+
+            // When the closed component looks like an IgxChartMenuComponent and _dialogId is set, tabsMenu.open should be called
+            expect(mockTabsMenu.open).toHaveBeenCalled();
+        });
+
+        it('should not open tabsMenu when closing event has no componentRef', () => {
+            (component as any)._dialogId = 'dialog-id';
+
+            (mockOverlay.closing as Subject<any>).next({ componentRef: undefined });
+
+            expect(mockTabsMenu.open).not.toHaveBeenCalled();
+        });
+    });
+
+    describe('overlayService.opening with chartDialogResizeNotify', () => {
+        it('should not throw when opening event has no componentRef', () => {
+            expect(() => {
+                (mockOverlay.opening as Subject<any>).next({ componentRef: undefined });
+            }).not.toThrow();
+        });
+    });
+
+    describe('constructor', () => {
+        it('should initialize chartImages and conditionImages', () => {
+            expect(component.chartImages).toBeDefined();
+            expect(component.conditionImages).toBeDefined();
+        });
+    });
+
+    describe('toggleTabMenu with target setting', () => {
+        it('should set the overlay target to the button nativeElement', () => {
+            component.toggleTabMenu();
+            expect((component as any)._tabsMenuOverlaySettings.target).toBe(component.button.nativeElement);
+        });
+
+        it('should preserve currentChartType if already set', () => {
+            component.currentChartType = CHART_TYPE.Pie;
+            component.toggleTabMenu();
+            expect(component.currentChartType).toBe(CHART_TYPE.Pie);
+        });
+    });
 });