Move all elements specific members from the angular grids into angular-element's source. by MayaKirova · Pull Request #15304 · IgniteUI/igniteui-angular

MayaKirova · 2025-01-27T14:25:53Z

Closes #15235

Additional information (check all that apply):

Checklist:

All relevant tags have been applied to this PR
This PR includes unit tests covering all the new code (test guidelines)
This PR includes API docs for newly added methods/properties (api docs guidelines)
This PR includes feature/README.MD updates for the feature docs
This PR includes general feature table updates in the root README.MD
This PR includes CHANGELOG.MD updates for newly added functionality
This PR contains breaking changes
This PR includes ng update migrations for the breaking changes (migrations guidelines)
This PR includes behavioral changes and the feature specification has been updated with them

dkamburov · 2025-03-26T15:23:39Z

@MayaKirova there is a conflict here

dkamburov · 2025-06-16T13:04:45Z

@MayaKirova please resolve the conflicts here

…ublic.

github-actions · 2025-08-17T00:16:51Z

There has been no recent activity and this PR has been marked inactive.

dkamburov · 2025-09-12T07:38:39Z

@MayaKirova there is a conflict here

…t.ts Co-authored-by: Damyan Petev <damyanpetev@users.noreply.github.com>

…teui-angular into mkirova/feat-15235

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

projects/igniteui-angular-elements/src/lib/grids/grid.component.ts

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

damyanpetev · 2026-04-06T09:30:13Z

projects/igniteui-angular/grids/grid/src/grid-base.directive.ts

    /** @hidden @internal */
-    @ContentChildren(IgxActionStripToken)
-    protected actionStripComponents: QueryList<IgxActionStripToken>;
+    @ContentChild(IgxActionStripToken)
+    public actionStripComponent: IgxActionStripToken;


That was protected before, can we keep it as such? Would like to avoid adding more "internal public" props where possible.

damyanpetev · 2026-04-06T09:39:11Z

projects/igniteui-angular-elements/src/analyzer/elements.config.ts

@@ -555,6 +557,7 @@ export var registerConfig = [
      },
    ],
    additionalProperties: [
+      { name: "childLayoutList", writable: true },


Unless these are needed (they weren't exposed before), I'd really prefer if they stay hidden

damyanpetev · 2026-04-06T09:39:52Z

projects/igniteui-angular-elements/src/analyzer/elements.config.ts

    selector: "igc-row-island",
-    parents: [IgxHierarchicalGridComponent, IgxRowIslandComponent],
+    parents: [
+      IgxGridComponent,


Yeah, that's off a bit, IgxGridComponent is not a valid parent or am I missing something?

fix(elements): Apply wc alternate name tag instead.

skrustev · 2026-04-09T08:17:58Z

@MayaKirova It seems like the columnsAutogenerated event doesn't fire for the RowIslands in Elements. I tested it with a previous version of the WC Grid and it seems to be working. For some reason also after building in the analyzer the Hierarchical Grid event doesn't fire, even though it fires here in the samples. Not sure if I'm doing something wrong

MayaKirova · 2026-04-09T12:59:23Z

@skrustev columnsAutogenerated should re-emit for row islands now.

MKirova added 4 commits January 21, 2025 14:58

feat(elements): Move elements specific members of IgxGrid into elements.

c893f91

feat(igxHGrid): Extract elements specific members for hgrid.

fe6512f

chore(*): Move row island elements specific members to elements.

f3b3821

chore(*): Extract tree grid elements members into elements.

45df002

MayaKirova added refactoring 💠 grid: elements labels Jan 27, 2025

MayaKirova requested a review from damyanpetev January 27, 2025 14:25

MayaKirova assigned dkamburov Jan 27, 2025

dkamburov requested a review from skrustev February 4, 2025 09:21

skrustev previously approved these changes Feb 13, 2025

View reviewed changes

dkamburov assigned MarielaTihova Feb 25, 2025

MarielaTihova added the ✅ status: verified Applies to PRs that have passed manual verification label Mar 17, 2025

Merge branch 'master' into mkirova/feat-15235

e05e080

MayaKirova dismissed skrustev’s stale review via e05e080 March 26, 2025 15:31

skrustev self-requested a review April 15, 2025 07:47

skrustev previously approved these changes Apr 15, 2025

View reviewed changes

dkamburov added the version: 20.0.x label Jun 3, 2025

Merge branch 'master' into mkirova/feat-15235

a993149

MayaKirova dismissed skrustev’s stale review via a993149 June 17, 2025 08:21

MKirova added 3 commits June 17, 2025 11:26

chore(*): Bring back selectedRowsChange in base since it has become p…

dd53412

…ublic.

Merge branch 'master' into mkirova/feat-15235

50e159d

chore(*): Fix build errors.

cbad25d

github-actions bot added the status: inactive Used to stale issues and pull requests label Aug 17, 2025

dkamburov removed the status: inactive Used to stale issues and pull requests label Aug 19, 2025

skrustev self-requested a review August 26, 2025 11:12

skrustev previously approved these changes Aug 26, 2025

View reviewed changes

kdinev and others added 7 commits April 2, 2026 15:02

Merge branch 'master' into mkirova/feat-15235

c223237

Update projects/igniteui-angular-elements/src/lib/grids/grid.componen…

37a528c

…t.ts Co-authored-by: Damyan Petev <damyanpetev@users.noreply.github.com>

chore(*): Apply review comments.

5fb2f19

chore(*): regenerate config.

949f435

Merge branch 'mkirova/feat-15235' of https://github.com/IgniteUI/igni…

59d957e

…teui-angular into mkirova/feat-15235

chore(*): Move two-way bind emitter in elements.

80fc01b

Update projects/igniteui-angular-elements/src/lib/grids/events.ts

f654099

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-code-quality bot found potential problems Apr 2, 2026

View reviewed changes

projects/igniteui-angular-elements/src/lib/grids/grid.component.ts Fixed Show fixed Hide fixed

MayaKirova and others added 2 commits April 2, 2026 17:57

Potential fix for pull request finding 'Expression has no effect'

d2fe83c

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

chore(*): Use aliases so that igxParent don't have to change.

6d1c52b

damyanpetev reviewed Apr 6, 2026

View reviewed changes

chore(*): apply review comments

9648222

MayaKirova requested a review from damyanpetev April 6, 2026 10:55

damyanpetev previously approved these changes Apr 6, 2026

View reviewed changes

chore(*): Move comments to correct place.

1a3fd79

MayaKirova dismissed damyanpetev’s stale review via 1a3fd79 April 6, 2026 13:17

skrustev and others added 2 commits April 7, 2026 10:30

fix(elements): Apply wc alternate name tag instead.

804680d

Merge pull request #17165 from IgniteUI/skrastev/feat-15235-aliaz

1ca0231

fix(elements): Apply wc alternate name tag instead.

skrustev added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Apr 8, 2026

skrustev added ❌ status: awaiting-test PRs awaiting manual verification and removed ✅ status: verified Applies to PRs that have passed manual verification labels Apr 9, 2026

MayaKirova added 3 commits April 9, 2026 15:47

chore(*): Make sure elements specific events re-emit for row island.

2257b3c

Merge branch 'master' into mkirova/feat-15235

ec31203

chore(*): Move actionStripComponents.changes to elements.

14ce17e

MayaKirova added 3 commits April 9, 2026 16:14

chore(*): revert Move actionStripComponents.changes to elements."

31f6ffa

chore(*): Move actionStripComponents back to base.

e350400

fix(row-island): change actionStripComponents visibility to public.

e4fada2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move all elements specific members from the angular grids into angular-element's source. #15304

Move all elements specific members from the angular grids into angular-element's source. #15304
MayaKirova wants to merge 41 commits intomasterfrom
mkirova/feat-15235

MayaKirova commented Jan 27, 2025

Uh oh!

dkamburov commented Mar 26, 2025

Uh oh!

dkamburov commented Jun 16, 2025

Uh oh!

github-actions bot commented Aug 17, 2025

Uh oh!

dkamburov commented Sep 12, 2025

Uh oh!

Uh oh!

damyanpetev Apr 6, 2026

Uh oh!

damyanpetev Apr 6, 2026

Uh oh!

damyanpetev Apr 6, 2026

Uh oh!

skrustev commented Apr 9, 2026 •

edited

Loading

Uh oh!

MayaKirova commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

MayaKirova commented Jan 27, 2025

Additional information (check all that apply):

Checklist:

Uh oh!

dkamburov commented Mar 26, 2025

Uh oh!

dkamburov commented Jun 16, 2025

Uh oh!

github-actions bot commented Aug 17, 2025

Uh oh!

dkamburov commented Sep 12, 2025

Uh oh!

Uh oh!

damyanpetev Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

damyanpetev Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

damyanpetev Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

skrustev commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MayaKirova commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

skrustev commented Apr 9, 2026 •

edited

Loading