feat(pivotGrid): Improve PivotGrid visually when there's no data or has empty area at the bottom.#15376
Merged
damyanpetev merged 18 commits intomasterfrom Mar 11, 2025
Merged
Conversation
…nd is in horizontal layout.
Applicable when there's no data or all rows are less than grid height.
skrustev
added
❌ status: awaiting-test
skrustev
added
🛠️ status: in-development
skrustev
added
❌ status: awaiting-test
…tent when parent has no width.
Member
Author
|
@simeonoff |
mddragnev
previously approved these changes
Feb 21, 2025
simeonoff
previously approved these changes
Feb 24, 2025
Comment on lines
3495
to
3514
| .igx-grid__tbody-pivot-dimension { | ||
| > .igx-grid-thead__wrapper { | ||
| border-bottom: initial; | ||
| } | ||
|
|
||
| .igx-grid-th { | ||
| height: 100%; | ||
| } | ||
| } | ||
|
|
||
| %igx-grid__tbody-pivot-mrl-dimension { | ||
| > .igx-grid-thead__wrapper { | ||
| border-bottom: initial; | ||
| } | ||
|
|
||
| .igx-grid-th { | ||
| height: 100%; | ||
| border-bottom: none; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Not BEM compliant but will accept for now as the grid styles will be completely rewritten in the coming sprints.
MarielaTihova
added
👀 status: in-review
…Add separate fill style and template.
MarielaTihova
added
✅ status: verified
mddragnev
approved these changes
Mar 7, 2025
simeonoff
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15366
Old vs new pivot grid loading vertical layout:
Old vs new pivot grid with horizontal layout:
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)