-
Notifications
You must be signed in to change notification settings - Fork 160
feat(pivotGrid): Improve PivotGrid visually when there's no data or has empty area at the bottom. #15376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat(pivotGrid): Improve PivotGrid visually when there's no data or has empty area at the bottom. #15376
Changes from 10 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
087cb3a
fix(pivotGrid): Do not render empty columns for PivotGrid when there'…
skrustev 14e991d
fix(pivotGrid): Fix empty space at the bottom of Pivot Grid due to ng…
skrustev 770d3ef
fix(pivotGrid): Fix empty space for body when there's still no data a…
skrustev a9c4070
feat(pivotGrid): Add row columns area to fill empty space.
skrustev 9858ca0
chore(*): Clear old import and add more info.
skrustev 1c09b20
feat(pivotGrid): Unify row dimension sections width when there's no d…
skrustev ac22809
chore(*): Remove unnecessary nesting css selector.
skrustev eaa8a04
chore(*): Fix wrong column import
skrustev c758315
fix(pivotGrid): Fix inital size of pivot grid not sizing based on con…
skrustev b93db8e
Merge branch 'master' into skrastev/pivot-grid-empy-enh
simeonoff 55017cf
fix(pivotGrid): Cover additional cases for empty row dimension list. …
skrustev b2c9e90
Merge master into skrastev/pivot-grid-empty-enh
skrustev b9bc721
chore(*): Apply back track function after merge.
skrustev c0d79f6
chore(*): Remove back track function due to duplicate keys.
skrustev 4e8f64a
chore(*): Remove unused import.
skrustev 7373ea4
Merge branch 'master' into skrastev/pivot-grid-empy-enh
e17d931
Merge branch 'master' into skrastev/pivot-grid-empy-enh
simeonoff cd2bb4a
Merge branch 'master' into skrastev/pivot-grid-empy-enh
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,31 +1,34 @@ | ||
| <div class="sample-flex-row"> | ||
| <button igxButton="outlined" (click)="saveState()">SAVE STATE</button> | ||
| <button igxButton="contained" (click)="restoreState()">RESTORE STATE</button> | ||
| <button igxButton="contained" (click)="export()">EXPORT</button> | ||
| <igx-switch [checked]="pivotUI.showRowHeaders" (change)="onShowHeadersToggle($event)">Show headers</igx-switch> | ||
| <igx-switch [checked]="pivotUI.rowLayout === 'horizontal'" (change)="onLayoutToggle($event)">Horizontal layout</igx-switch> | ||
| <div class="pivot-container"> | ||
| <div> | ||
| <igx-pivot-grid | ||
| #grid1 | ||
| [igxGridState]="options" | ||
| (valueInit)='onValueInit($event)' | ||
| (dimensionInit)='onDimensionInit($event)' | ||
| [data]="origData" | ||
| [width]="'100%'" | ||
| [height]="'800px'" | ||
| [superCompactMode]="true" | ||
| [defaultExpandState]="true" | ||
| [pivotConfiguration]="pivotConfigHierarchy" | ||
| [pivotUI]="pivotUI" | ||
| [allowFiltering]="true" | ||
| [filterMode]="'quickFilter'" | ||
| [rowSelection]="'single'" | ||
| > | ||
| <ng-template igxPivotRowDimensionHeader let-col> | ||
| <span>{{col.header}} 📐</span> | ||
| </ng-template> | ||
| </igx-pivot-grid> | ||
| <button igxButton="outlined" (click)="saveState()">SAVE STATE</button> | ||
| <button igxButton="contained" (click)="restoreState()">RESTORE STATE</button> | ||
| <button igxButton="contained" (click)="export()">EXPORT</button> | ||
| <igx-switch [checked]="pivotUI.showRowHeaders" (change)="onShowHeadersToggle($event)">Show headers</igx-switch> | ||
| <igx-switch [checked]="pivotUI.rowLayout === 'horizontal'" (change)="onLayoutToggle($event)">Horizontal layout</igx-switch> | ||
| </div> | ||
| <div class="pivot-container"> | ||
| <div style="width: 100%;"> | ||
| <igx-pivot-grid | ||
| #grid1 | ||
| [igxGridState]="options" | ||
| (valueInit)='onValueInit($event)' | ||
| (dimensionInit)='onDimensionInit($event)' | ||
| [data]="origData" | ||
| [width]="'100%'" | ||
| [height]="'800px'" | ||
| [superCompactMode]="true" | ||
| [defaultExpandState]="true" | ||
| [pivotConfiguration]="pivotConfigHierarchy" | ||
| [pivotUI]="pivotUI" | ||
| [allowFiltering]="true" | ||
| [filterMode]="'quickFilter'" | ||
| [rowSelection]="'single'" | ||
| > | ||
| <ng-template igxPivotRowDimensionHeader let-col> | ||
| <span>{{col.header}} 📐</span> | ||
| </ng-template> | ||
| </igx-pivot-grid> | ||
| </div> | ||
| <igx-pivot-data-selector [grid]="grid1"></igx-pivot-data-selector> | ||
| </div> | ||
| <igx-pivot-data-selector [grid]="grid1"></igx-pivot-data-selector> | ||
| </div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not BEM compliant but will accept for now as the grid styles will be completely rewritten in the coming sprints.