Skip to content

chore(*): fix typos in misc tests #15431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChronosSF merged 3 commits into from
Mar 5, 2025
Merged

chore(*): fix typos in misc tests #15431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5e6afd
chore(*): fix typos in misc tests
damyanpetev Feb 28, 2025
b0d104a
Merge branch 'master' into dpetev/misc-test-typos
ChronosSF Mar 5, 2025
a572523
fix(tests): fixing wrongly changed test
ChronosSF Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,13 @@
"javascript.preferences.quoteStyle": "single",
"typescript.preferences.quoteStyle": "single",
"cSpell.words": [
"aria-describedby",
"aria-haspopup",
"aria-labelledby",
"ghostclass",
"groupable",
"groupby",
"maxlength",
"ungroup"
]
}
}
2 changes: 1 addition & 1 deletion projects/igniteui-angular/src/lib/drop-down/drop-down.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,7 +926,7 @@ describe('IgxDropDown ', () => {
});
});
});
describe('Virtualisation tests', () => {
describe('Virtualization tests', () => {
let scroll: IgxForOfDirective<any>;
let items;
configureTestSuite();
Expand Down
10 changes: 5 additions & 5 deletions projects/igniteui-angular/src/lib/grids/grid/grid-cell-editing.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import { Subject, fromEvent } from 'rxjs';
import { SortingDirection } from '../../data-operations/sorting-strategy';
import { IGridEditDoneEventArgs, IGridEditEventArgs, IgxColumnComponent } from '../public_api';

const DEBOUNCETIME = 30;
const DEBOUNCE_TIME = 30;
const CELL_CSS_CLASS = '.igx-grid__td';
const CELL_CSS_CLASS_NUMBER_FORMAT = '.igx-grid__td--number';
const CELL_CLASS_IN_EDIT_MODE = 'igx-grid__td--editing';
Expand Down Expand Up @@ -469,7 +469,7 @@ describe('IgxGrid - Cell Editing #grid', () => {

UIInteractions.triggerKeyDownEvtUponElem('ArrowDown', inputElem, true);
fixture.detectChanges();
await wait(DEBOUNCETIME);
await wait(DEBOUNCE_TIME);

inputElem = document.activeElement as HTMLInputElement;
expect(cell.editMode).toBeTruthy();
Expand Down Expand Up @@ -499,7 +499,7 @@ describe('IgxGrid - Cell Editing #grid', () => {

UIInteractions.triggerKeyDownEvtUponElem('ArrowUp', inputElem, true);
fixture.detectChanges();
await wait(DEBOUNCETIME);
await wait(DEBOUNCE_TIME);

inputElem = document.activeElement as HTMLInputElement;
expect(cell.editMode).toBeTruthy();
Expand All @@ -524,7 +524,7 @@ describe('IgxGrid - Cell Editing #grid', () => {

UIInteractions.triggerKeyDownEvtUponElem('arrowright', inputElem, true);
fixture.detectChanges();
await wait(DEBOUNCETIME);
await wait(DEBOUNCE_TIME);

const displayContainer = parseInt(virtRow.dc.instance._viewContainer.element.nativeElement.style.left, 10);
expect(cell.editMode).toBeTruthy();
Expand All @@ -551,7 +551,7 @@ describe('IgxGrid - Cell Editing #grid', () => {
expect(cellElem.classList.contains(CELL_CLASS_IN_EDIT_MODE)).toBe(true);
const virtRowStyle = parseInt(virtRow.dc.instance._viewContainer.element.nativeElement.style.left, 10);
UIInteractions.triggerKeyDownEvtUponElem('ArrowLeft', inputElem, fixture);
await wait(DEBOUNCETIME);
await wait(DEBOUNCE_TIME);
fixture.detectChanges();

inputElem = document.activeElement as HTMLInputElement;
Expand Down
2 changes: 1 addition & 1 deletion projects/igniteui-angular/src/lib/grids/grid/grid-collapsible-columns.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ describe('IgxGrid - multi-column headers #grid', () => {

GridFunctions.verifyGroupIsExpanded(fixture, secondGroup);

GridFunctions.verifyColumnIsHidden(grid.getColumnByName('PostlCode'), false, 6);
GridFunctions.verifyColumnIsHidden(grid.getColumnByName('PostalCode'), false, 6);

// delete another column
fixture.componentInstance.columnGroups[1].columns = fixture.componentInstance.columnGroups[1].columns.splice(2);
Expand Down
12 changes: 6 additions & 6 deletions projects/igniteui-angular/src/lib/grids/grid/grid-filtering-advanced.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ describe('IgxGrid - Advanced Filtering #grid - ', () => {
]
});
}));

describe('General tests - ', () => {
let fix: ComponentFixture<IgxGridAdvancedFilteringComponent>;
let grid: IgxGridComponent;
Expand Down Expand Up @@ -434,13 +434,13 @@ describe('IgxGrid - Advanced Filtering #grid - ', () => {
grid.openAdvancedFilteringDialog();
fix.detectChanges();

// Verfiy there is a root group with 'And' operator line and 2 children.
// Verify there is a root group with 'And' operator line and 2 children.
const rootGroup = QueryBuilderFunctions.getQueryBuilderTreeRootGroup(fix);
expect(rootGroup).not.toBeNull();
QueryBuilderFunctions.verifyOperatorLine(QueryBuilderFunctions.getQueryBuilderTreeRootGroupOperatorLine(fix) as HTMLElement, 'and');
expect(QueryBuilderFunctions.getQueryBuilderTreeChildItems(rootGroup as HTMLElement).length).toBe(2);

// Verify the contnet of the first child (expression) of the root group.
// Verify the content of the first child (expression) of the root group.
QueryBuilderFunctions.verifyExpressionChipContent(fix, [1], 'Downloads', 'Greater Than', '100');

// Verify the content of the second child (group) of the root group.
Expand Down Expand Up @@ -1225,11 +1225,11 @@ describe('IgxGrid - Advanced Filtering #grid - ', () => {
tick(100);
fix.detectChanges();


// Populate edit inputs.
QueryBuilderFunctions.selectColumnInEditModeExpression(fix, 1); // Select 'ProductName' column.
QueryBuilderFunctions.selectOperatorInEditModeExpression(fix, 0); // Select 'Contains' operator.

let input = QueryBuilderFunctions.getQueryBuilderValueInput(fix).querySelector('input');
UIInteractions.clickAndSendInputElementValue(input, 'angular', fix); // Type filter value.
// Commit the populated expression.
Expand Down Expand Up @@ -1278,7 +1278,7 @@ describe('IgxGrid - Advanced Filtering #grid - ', () => {
grid = fix.componentInstance.grid;
fix.detectChanges();
}));

it('Should allow hosting Advanced Filtering dialog outside of the grid.', fakeAsync(() => {
// Add a root 'and' group.
QueryBuilderFunctions.clickQueryBuilderInitialAddConditionBtn(fix, 0);
Expand Down
Loading
Loading