fix(query-builder): returnFields should be '*' on entity change / all fileds are selected#15445
Merged
gedinakova merged 6 commits intomasterfrom Mar 12, 2025
Merged
Conversation
teodosiah
added
❌ status: awaiting-test
gedinakova
requested changes
Mar 7, 2025
| this._expressionTree.entity = this._entityNewValue.name; | ||
| this._expressionTree.returnFields = []; | ||
|
|
||
| if (this.fields.length === this._selectedReturnFields.length) { |
Contributor
There was a problem hiding this comment.
Could be done with a ternary expression as well.
|
|
||
| // Verify the returnFields | ||
| exprTreeReturnFields = JSON.stringify(fix.componentInstance.queryBuilder.expressionTree.returnFields); | ||
| expect(exprTreeReturnFields).toBe(`["*"]`); |
Contributor
There was a problem hiding this comment.
How about the case when all fields get explicitly checked again or via the "Select All" checkbox (for the same entity)? This is not covered in a test and doesn't seem to work yet.
gedinakova
added
💥 status: in-test
gedinakova
approved these changes
Mar 12, 2025
gedinakova
added
✅ status: verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)