Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,13 @@ export class IgxQueryBuilderTreeComponent implements AfterViewInit, OnDestroy {

if (this._expressionTree) {
this._expressionTree.entity = this._entityNewValue.name;
this._expressionTree.returnFields = [];

if (this.fields.length === this._selectedReturnFields.length) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be done with a ternary expression as well.

this._expressionTree.returnFields = ['*'];
} else {
this._expressionTree.returnFields = this._selectedReturnFields;
}

this._expressionTree.filteringOperands = [];

this._editedExpression = null;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,32 @@ describe('IgxQueryBuilder', () => {
expect((dropdownItems[4] as HTMLElement).innerText).toBe('Released');
}));

it('ReturnFields should be properly calculated.', fakeAsync(() => {
queryBuilder.expressionTree = QueryBuilderFunctions.generateExpressionTree();
queryBuilder.showEntityChangeDialog = false;
fix.detectChanges();

// Verify the returnFields
let exprTreeReturnFields = JSON.stringify(fix.componentInstance.queryBuilder.expressionTree.returnFields);
expect(exprTreeReturnFields).toBe(`["*"]`);

// Change the selected return fields
QueryBuilderFunctions.selectFieldsInEditModeExpression(fix, [1]);
tick(100);
fix.detectChanges();

// Verify the returnFields
exprTreeReturnFields = JSON.stringify(fix.componentInstance.queryBuilder.expressionTree.returnFields);
expect(exprTreeReturnFields).toBe(`["OrderId"]`);

// Change the entity
QueryBuilderFunctions.selectEntityAndClickInitialAddCondition(fix, 0);

// Verify the returnFields
exprTreeReturnFields = JSON.stringify(fix.componentInstance.queryBuilder.expressionTree.returnFields);
expect(exprTreeReturnFields).toBe(`["*"]`);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the case when all fields get explicitly checked again or via the "Select All" checkbox (for the same entity)? This is not covered in a test and doesn't seem to work yet.

}));

it('Column dropdown should contain proper fields based on the entity.', fakeAsync(() => {
const queryBuilderElement: HTMLElement = fix.debugElement.queryAll(By.css(`.${QueryBuilderSelectors.QUERY_BUILDER_TREE}`))[0].nativeElement;

Expand Down