Skip to content

API analyzer adjustments 19.1 #15451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damyanpetev merged 4 commits into from
Mar 10, 2025
Merged

API analyzer adjustments 19.1 #15451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5996f9
chore(filter-operands): restore findValueInSet as protected
damyanpetev Mar 4, 2025
f61035b
refactor(grids): move navigation overrides to existing ctor props
damyanpetev Mar 4, 2025
73a9387
fix(elements): export overlay settings enums
damyanpetev Mar 10, 2025
041ff52
docs(filtering): mark operand as internal for now
damyanpetev Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions projects/igniteui-angular-elements/src/public_api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,14 @@ import { IgxPivotAggregate, IgxPivotDateAggregate, IgxPivotNumericAggregate, Igx
import { IgxPivotDateDimension } from 'projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid-dimensions';
import { PivotDimensionType } from 'projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid.interface';
import { IgxDateSummaryOperand, IgxNumberSummaryOperand, IgxSummaryOperand, IgxTimeSummaryOperand } from 'projects/igniteui-angular/src/lib/grids/summaries/grid-summary';
import { HorizontalAlignment, VerticalAlignment } from 'projects/igniteui-angular/src/lib/services/overlay/utilities';


/** Export Public API, TODO: reorganize, Generate all w/ renames? */
export {
//Grids API
FilteringExpressionsTree as IgcFilteringExpressionsTree,
FilteringLogic, // TODO: already exported by analyzer?
FilteringLogic,
FilteringExpressionsTreeType,
IgxFilteringOperand as IgcFilteringOperand,
IgxBooleanFilteringOperand as IgcBooleanFilteringOperand,
Expand Down Expand Up @@ -48,5 +49,9 @@ export {
RowPinningPosition,
GridPagingMode,
DropPosition,
PivotDimensionType
PivotDimensionType,

// overlay position settings (used in grids, paginator, toolbar)
HorizontalAlignment,
VerticalAlignment,
}
34 changes: 13 additions & 21 deletions projects/igniteui-angular/src/lib/data-operations/filtering-condition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,12 @@ export class IgxFilteringOperand {
* Returns an array of names of the conditions which are visible in the filtering UI
*/
public conditionList(): string[] {
return this.operations.filter(f => !f.hidden && !f.isNestedQuery).map((element) => element.name);
return this.operations.filter(f => !f.hidden && !f.isNestedQuery).map((element) => element.name);
}

/**
* Returns an array of names of the conditions which are visible in the UI, including "In" and "Not In", allowing the creation of sub-queries.
* @hidden @internal
*/
public extendedConditionList(): string[] {
return this.operations.filter(f => !f.hidden).map((element) => element.name);
Expand All @@ -76,10 +77,7 @@ export class IgxFilteringOperand {
this.operations.push(operation);
}

/**
* @hidden
*/
public findValueInSet(target: any, searchVal: Set<any>) {
protected findValueInSet(target: any, searchVal: Set<any>) {
return searchVal.has(target);
}
}
Expand Down Expand Up @@ -119,7 +117,7 @@ export class IgxBooleanFilteringOperand extends IgxFilteringOperand {
iconName: 'filter_not_empty',
logic: (target: boolean) => target !== null && target !== undefined
}];

this.operations = newOperations.concat(this.operations);
}
}
Expand All @@ -143,7 +141,7 @@ class IgxBaseDateTimeFilteringOperand extends IgxFilteringOperand {
iconName: 'filter_not_empty',
logic: (target: Date) => target !== null && target !== undefined
}];

this.operations = newOperations.concat(this.operations);
}

Expand Down Expand Up @@ -189,10 +187,7 @@ class IgxBaseDateTimeFilteringOperand extends IgxFilteringOperand {
return res;
}

/**
* @hidden
*/
public override findValueInSet(target: any, searchVal: Set<any>) {
protected override findValueInSet(target: any, searchVal: Set<any>) {
if (!target) {
return false;
}
Expand Down Expand Up @@ -416,11 +411,11 @@ export class IgxDateFilteringOperand extends IgxBaseDateTimeFilteringOperand {
return d.year === now.year + 1;
}
}];

this.operations = newOperations.concat(this.operations);
}

public override findValueInSet(target: any, searchVal: Set<any>) {
protected override findValueInSet(target: any, searchVal: Set<any>) {
if (!target) {
return false;
}
Expand Down Expand Up @@ -637,7 +632,7 @@ export class IgxDateTimeFilteringOperand extends IgxBaseDateTimeFilteringOperand
return d.year === now.year + 1;
}
}];

this.operations = newOperations.concat(this.operations);
}
}
Expand Down Expand Up @@ -741,14 +736,11 @@ export class IgxTimeFilteringOperand extends IgxBaseDateTimeFilteringOperand {
true : targetn.hours === search.hours && targetn.minutes === search.minutes && targetn.seconds > search.seconds;
}
}];

this.operations = newOperations.concat(this.operations);
}

/**
* @hidden
*/
public override findValueInSet(target: any, searchVal: Set<any>) {
protected override findValueInSet(target: any, searchVal: Set<any>) {
if (!target) {
return false;
}
Expand Down Expand Up @@ -806,7 +798,7 @@ export class IgxNumberFilteringOperand extends IgxFilteringOperand {
iconName: 'filter_not_empty',
logic: (target: number) => target !== null && target !== undefined && !isNaN(target)
}];

this.operations = newOperations.concat(this.operations);
}
}
Expand Down Expand Up @@ -885,7 +877,7 @@ export class IgxStringFilteringOperand extends IgxFilteringOperand {
iconName: 'filter_not_empty',
logic: (target: string) => target !== null && target !== undefined && target.length > 0
}];

this.operations = newOperations.concat(this.operations);
}

Expand Down
4 changes: 1 addition & 3 deletions ...ects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid-base.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ export abstract class IgxHierarchicalGridBaseDirective extends IgxGridBaseDirect
viewRef: ViewContainerRef,
injector: Injector,
envInjector: EnvironmentInjector,
navigation: IgxHierarchicalGridNavigationService,
public override navigation: IgxHierarchicalGridNavigationService,
filteringService: IgxFilteringService,
textHighlightService: IgxTextHighlightService,
@Inject(IgxOverlayService) overlayService: IgxOverlayService,
Expand Down Expand Up @@ -200,8 +200,6 @@ export abstract class IgxHierarchicalGridBaseDirective extends IgxGridBaseDirect
);
}

public override navigation: IgxHierarchicalGridNavigationService;

/**
* @hidden
*/
Expand Down
4 changes: 1 addition & 3 deletions projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1021,7 +1021,7 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni
viewRef: ViewContainerRef,
injector: Injector,
envInjector: EnvironmentInjector,
navigation: IgxPivotGridNavigationService,
public override navigation: IgxPivotGridNavigationService,
filteringService: IgxFilteringService,
textHighlightService: IgxTextHighlightService,
@Inject(IgxOverlayService) overlayService: IgxOverlayService,
Expand Down Expand Up @@ -1054,8 +1054,6 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni
_diTransactions);
}

public override navigation: IgxPivotGridNavigationService;

/**
* @hidden
*/
Expand Down