fix(grid): fixed advancedFilteringExpressionsTree rehydration #15500#15507
Merged
damyanpetev merged 12 commits into19.1.xfrom Mar 18, 2025
Merged
fix(grid): fixed advancedFilteringExpressionsTree rehydration #15500#15507damyanpetev merged 12 commits into19.1.xfrom
damyanpetev merged 12 commits into19.1.xfrom
Conversation
Contributor
|
@Otixa Since 'condition' is not a mandatory property, is there a reason to require having it. Check this out in the focused test. Essentialy, the following is not a valid structure: this.filterTree = JSON.parse(`{
"filteringOperands": [
{
"conditionName": "greaterThan",
"fieldName": "Downloads",
"searchVal": 200
}
],
"operator": 0
}`);While this one is valid: this.filterTree = JSON.parse(`{
"filteringOperands": [
{
"conditionName": "greaterThan",
"condition":{
"name":"greaterThan",
"isUnary":false,
"iconName":"filter_greater_than"
},
"fieldName": "Downloads",
"searchVal": 200
}
],
"operator": 0
}`);I would expect both to work as we don't get much from having the condition prop. I realize in most cases it will be created via stringifying the actual object, hence this issue will not surface, but I still think we can reconsider. |
gedinakova
previously approved these changes
Mar 17, 2025
gedinakova
previously approved these changes
Mar 17, 2025
damyanpetev
previously approved these changes
Mar 18, 2025
damyanpetev
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15500
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)