Skip to content

[Query Builder] drag and drop refactor without DOM manipulations - 19.1.x#15537

Merged
ChronosSF merged 54 commits into19.1.xfrom
ipetrov/query-builder-drag-and-drop-refactor-remake2-19.1.x
Mar 18, 2025
Merged

[Query Builder] drag and drop refactor without DOM manipulations - 19.1.x#15537
ChronosSF merged 54 commits into19.1.xfrom
ipetrov/query-builder-drag-and-drop-refactor-remake2-19.1.x

Conversation

@ivanvpetrov
Copy link
Copy Markdown
Contributor

@ivanvpetrov ivanvpetrov commented Mar 18, 2025

Branch and PR remake to try solve test disconnecting issue

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

ivanvpetrov added 30 commits March 6, 2025 13:42
@ivanvpetrov
refactor(query-builder): drag and drop without DOM manipulations
1746f32
@ivanvpetrov
test(query-builder): fix failing keyboard test
75c9dc1
@ivanvpetrov
fix(query-builder): test improved drag ghost siblings
7d5f618
@ivanvpetrov
fix(query-builder): test mouse drag test
b641658
@ivanvpetrov
fix(query-builder): test all passing now
b3d2efc
@ivanvpetrov
fix(query-builder): circular reference
2779468
@ivanvpetrov
fix(query-builder): test mosue drag now passing
c6e564d
@ivanvpetrov
test(query-builder): exclude disconnecting test
5df2da4
@ivanvpetrov
test(query-builder): exclude disconnecting test
97ee8e4
@ivanvpetrov
test(query-builder): exclude disconnecting test
dfcbe55
@ivanvpetrov
test(query-builder): exclude disconnecting test
cbc5d89
@ivanvpetrov
test(query-builder): exclude disconnecting test
62fc540
@ivanvpetrov
test(query-builder): exclude disconnecting test
35a5c42
@ivanvpetrov
test(query-builder): exclude disconnecting test
c3f73a0
@ivanvpetrov
test(query-builder): exclude disconnecting test
9f4005c
@ivanvpetrov
test(query-builder): exclude disconnecting test
4dd7da4
@ivanvpetrov
test(query-builder): exclude disconnecting test
89101c4
@ivanvpetrov
test(query-builder): exclude disconnecting test
522acba
@ivanvpetrov
test(query-builder): exclude disconnecting test
57814b8
@ivanvpetrov
test(query-builder): exclude disconnecting test
ac55f29
@ivanvpetrov
test(query-builder): exclude disconnecting test
cf99cb1
@ivanvpetrov
test(query-builder): exclude disconnecting test
4bb68b2
@ivanvpetrov
test(query-builder): exclude disconnecting test
78e22e6
@ivanvpetrov
test(query-builder): exclude disconnecting test
bf1fa3e
@ivanvpetrov
test(query-builder): exclude disconnecting test
f377ca0
@ivanvpetrov
test(query-builder): exclude disconnecting test
440c280
@ivanvpetrov
test(query-builder): exclude disconnecting test
526413d
@ivanvpetrov
test(query-builder): exclude disconnecting test
049a1bd
@ivanvpetrov
test(query-builder): exclude disconnecting test
bc8240a
@ivanvpetrov
test(query-builder): exclude disconnecting test
9c0a920
ivanvpetrov and others added 19 commits March 12, 2025 11:10
@ivanvpetrov
test(query-builder): exclude disconnecting test
2174a24
@ivanvpetrov
test(query-builder): exclude disconnecting test
eeb2402
@ivanvpetrov
Merge branch '19.1.x' into ipetrov/query-builder-drag-and-drop-refactor
01c4716
@ivanvpetrov
test(query-builder): exclude disconnecting test
3000304
@ivanvpetrov
fix(query-builder): drag&drop dropped chip highlight bug fixed
5ec1d0e
@ivanvpetrov
test(query-builder): exclude disconnecting test
a14da94
@desig9stein
fix(query-builder): fix drop placeholder and keyboard ghost element s…
9b10757 
…tyles
@teodosiah
refactor(query-builder): change how drag service is provided
1a0d413
@desig9stein
fix(query-builder): keyboard ghost element styles shadow based on theme
fb827df
@ivanvpetrov
chore(query-builder): apply code suggestion
fecf2d6
@ivanvpetrov
fix(query-builder): test style name fix
2b715fd
@ivanvpetrov
fix(query-builder): color of the keyboard drop ghost set
1941d1f
@desig9stein
fix(query-builder): Use the shadow variable for the chip
ca2df30
@gedinakova
Merge branch '19.1.x' into ipetrov/query-builder-drag-and-drop-refactor
d058289
@ivanvpetrov
Merge branch 'ipetrov/query-builder-drag-and-drop-refactor' into ipet…
4f5da5d 
…rov/query-builder-drag-and-drop-refactor-remake
@ChronosSF
Merge branch '19.1.x' into ipetrov/query-builder-drag-and-drop-refact…
44f1663 
…or-remake
@ivanvpetrov
test(query-builder): add keyboard drag commit and cancel tests
bda64d5
@ivanvpetrov
chore(query-builder): removed todo comment
df22f4b
@ivanvpetrov
Merge branch 'ipetrov/query-builder-drag-and-drop-refactor-remake' in…
aeee803 
…to ipetrov/query-builder-drag-and-drop-refactor-remake2-19.1.x
@gedinakova gedinakova requested a review from ChronosSF March 18, 2025 13:57
@ivanvpetrov ivanvpetrov changed the base branch from 19.1.x to master March 18, 2025 14:33
@ivanvpetrov ivanvpetrov changed the base branch from master to 19.1.x March 18, 2025 14:33
@ivanvpetrov ivanvpetrov changed the base branch from 19.1.x to master March 18, 2025 14:40
@ivanvpetrov ivanvpetrov changed the base branch from master to 19.1.x March 18, 2025 14:41
@ChronosSF ChronosSF merged commit 198d060 into 19.1.x Mar 18, 2025
7 of 13 checks passed
@ChronosSF ChronosSF deleted the ipetrov/query-builder-drag-and-drop-refactor-remake2-19.1.x branch March 18, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChronosSF ChronosSF ChronosSF approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ivanvpetrov @ChronosSF @desig9stein @teodosiah @gedinakova