Skip to content

[Card]: refactor spacing#15599

Merged
simeonoff merged 11 commits intomasterfrom
mpopov/refactoring/card/issue-15432
Mar 27, 2025
Merged

[Card]: refactor spacing#15599
simeonoff merged 11 commits intomasterfrom
mpopov/refactoring/card/issue-15432

Conversation

@desig9stein
Copy link
Copy Markdown
Contributor

@desig9stein desig9stein commented Mar 25, 2025

Closes #15432

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@didimmova
Copy link
Copy Markdown
Contributor

In the fluent theme, the header padding should be 16 all around, following the UI kit, currently, they're 16-8

Screenshot 2025-03-26 at 14 09 02

@andiesm813
Copy link
Copy Markdown

In the fluent theme, the header padding should be 16 all around, following the UI kit, currently, they're 16-8

Screenshot 2025-03-26 at 14 09 02

Agreed! That's the only issue i saw too @desig9stein

@andiesm813
Copy link
Copy Markdown

Fluent looks good now! ;) thanks for the quick fix @desig9stein

didimmova
didimmova previously approved these changes Mar 27, 2025
@desig9stein desig9stein requested review from didimmova and removed request for simeonoff March 27, 2025 07:10
@didimmova
Copy link
Copy Markdown
Contributor

Screenshot 2025-03-27 at 9 54 16

Some additional margin appeared on the actions in the bootstrap card

@desig9stein
Copy link
Copy Markdown
Contributor Author

Screenshot 2025-03-27 at 9 54 16 Some additional margin appeared on the actions in the bootstrap card

We have that for all themes, this is a margin-top auto of the actions when they are the last child, this is what pushes the buttons to the end of the card, it does not add up to the spacing between the card elements

@didimmova didimmova added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Mar 27, 2025
@simeonoff simeonoff merged commit 682ba7f into master Mar 27, 2025
5 checks passed
@simeonoff simeonoff deleted the mpopov/refactoring/card/issue-15432 branch March 27, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

card refactoring styling version: 19.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Card Component: inner paddings updated in Figma for all themes

4 participants