Refactor how the grid calculates the size of the body.#15603
Closed
MayaKirova wants to merge 14 commits intomasterfrom
Closed
Refactor how the grid calculates the size of the body.#15603MayaKirova wants to merge 14 commits intomasterfrom
MayaKirova wants to merge 14 commits intomasterfrom
Conversation
MayaKirova
added
❌ status: awaiting-test
15 tasks
|
There has been no recent activity and this PR has been marked inactive. |
github-actions
bot
added
the
status: inactive
Member
|
@MayaKirova Could you resolve the conflicts? |
mddragnev
added
✅ status: verified
|
There has been no recent activity and this PR has been marked inactive. |
github-actions
bot
added
the
status: inactive
|
There has been no recent activity and this PR has been marked inactive. |
github-actions
bot
added
the
status: inactive
|
There has been no recent activity and this PR has been marked inactive. |
github-actions
bot
added
the
status: inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #14048
This is point 2 of #14048 (comment)
Refactoring and simplifying some of the calculation around the calcHeight and calcWidth of the grid as well as adding some styles so that tbody content flexes correctly with the parent containers.
There should be automation for most scenarios, but still should be tested according to the sizing spec and topic for all grids.
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)