Skip to content

fix(action-strip): Assign parent to not destroy on DOM move.#15939

Closed
MayaKirova wants to merge 5 commits into20.0.xfrom
mkirova/fix-15768
Closed

fix(action-strip): Assign parent to not destroy on DOM move.#15939
MayaKirova wants to merge 5 commits into20.0.xfrom
mkirova/fix-15768

Conversation

@MayaKirova
Copy link
Copy Markdown
Contributor

@MayaKirova MayaKirova commented Jun 16, 2025

Closes #15768
Closes #15911

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@tishko0 tishko0 added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jun 19, 2025
@MayaKirova
Copy link
Copy Markdown
Contributor Author

Note to self - check why hide check of strip fails:

 public hide(): void {
        this.hidden = true;
        this.closeMenu();
        if (this._originalParent) {
            // D.P. fix(elements) don't detach native DOM, instead move back. Might not matter for Angular, but Elements will destroy
            this.renderer.appendChild(this._originalParent, this._viewContainer.element.nativeElement);
        } else if (this.context && this.context.element) {
            this.renderer.removeChild(this.context.element.nativeElement, this._viewContainer.element.nativeElement);
        }
    }

@MayaKirova MayaKirova changed the base branch from master to 20.0.x June 20, 2025 09:14
@MayaKirova MayaKirova removed the ✅ status: verified Applies to PRs that have passed manual verification label Jun 20, 2025
@MayaKirova MayaKirova added the ❌ status: awaiting-test PRs awaiting manual verification label Jun 20, 2025
@tishko0 tishko0 added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jun 23, 2025
@github-actions
Copy link
Copy Markdown

There has been no recent activity and this PR has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Aug 23, 2025
@github-actions github-actions bot closed this Aug 31, 2025
@dkamburov dkamburov reopened this Sep 1, 2025
@dkamburov dkamburov removed the status: inactive Used to stale issues and pull requests label Sep 1, 2025
@ChronosSF
Copy link
Copy Markdown
Member

20.0.x received its last patch and will no longer be supported.

@ChronosSF ChronosSF closed this Sep 29, 2025
@ChronosSF ChronosSF deleted the mkirova/fix-15768 branch September 29, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

4 participants