Skip to content

refactoring(query-builder): expose the outer padding as a css variable#15975

Merged
simeonoff merged 7 commits into20.0.xfrom
mpopov/query-builder/expuse-outer-padding-var
Jun 30, 2025
Merged

refactoring(query-builder): expose the outer padding as a css variable#15975
simeonoff merged 7 commits into20.0.xfrom
mpopov/query-builder/expuse-outer-padding-var

Conversation

@desig9stein
Copy link
Copy Markdown
Contributor

@desig9stein desig9stein commented Jun 23, 2025

Closes #15529

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

… of query builder outer paddings and tree section scrollbar gutter.
… of query builder outer paddings and tree section scrollbar gutter.
simeonoff
simeonoff previously approved these changes Jun 24, 2025
@simeonoff
Copy link
Copy Markdown
Collaborator

@desig9stein this should target the 20.0.x branch, not master. The 20.0.x mass merge PR has not yet been merged.

@simeonoff simeonoff self-requested a review June 24, 2025 12:08
@desig9stein desig9stein changed the base branch from master to 20.0.x June 24, 2025 14:12
@desig9stein desig9stein dismissed simeonoff’s stale review June 24, 2025 14:12

The base branch was changed.

pmoleri
pmoleri previously approved these changes Jun 26, 2025
Copy link
Copy Markdown
Contributor

@pmoleri pmoleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only doubt is if it's better to keep --_query-builder-outer-padding underscored as private or it could be exposed as a public option.

@simeonoff simeonoff merged commit 13bf65c into 20.0.x Jun 30, 2025
3 of 5 checks passed
@simeonoff simeonoff deleted the mpopov/query-builder/expuse-outer-padding-var branch June 30, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unnecessary outer paddings

4 participants