refactor(*): migrate DI from constructors to inject() API by IMinchev64 · Pull Request #16075 · IgniteUI/igniteui-angular

IMinchev64 · 2025-07-24T14:06:41Z

This PR refactors the entire Ignite UI for Angular component library to use the Angular inject() API instead of constructor-based dependency injection.

Additional information (check all that apply):

Checklist:

All relevant tags have been applied to this PR
This PR includes unit tests covering all the new code (test guidelines)
This PR includes API docs for newly added methods/properties (api docs guidelines)
This PR includes feature/README.MD updates for the feature docs
This PR includes general feature table updates in the root README.MD
This PR includes CHANGELOG.MD updates for newly added functionality
This PR contains breaking changes
This PR includes ng update migrations for the breaking changes (migrations guidelines)
This PR includes behavioral changes and the feature specification has been updated with them

…ctor-to-inject

Copilot

Pull Request Overview

This PR refactors the Ignite UI for Angular component library to use Angular's inject() API instead of constructor-based dependency injection, aligning with modern Angular best practices.

Key Changes:

Migration from constructor parameters to inject() function for dependency injection
Updates to test files to use TestBed for component instantiation instead of manual constructors
Conversion of injection tokens from string literals to InjectionToken objects

Reviewed Changes

Copilot reviewed 278 out of 278 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
projects/igniteui-angular/src/lib/tree/tree.component.ts	Migrated constructor DI to `inject()` API
projects/igniteui-angular/src/lib/tree/tree-node/tree-node.component.ts	Replaced constructor injection with `inject()` calls
projects/igniteui-angular/src/lib/tree/tree.spec.ts	Updated tests to use `TestBed` for component creation
projects/igniteui-angular/src/lib/time-picker/time-picker.common.ts	Changed token from string to `InjectionToken`
projects/igniteui-angular/src/lib/time-picker/time-picker.component.ts	Migrated to `inject()` API
projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid.component.ts	Removed large constructor, migrated to `inject()`
projects/igniteui-angular/src/lib/services/overlay/overlay.ts	Converted to `inject()` API
projects/igniteui-angular/src/lib/icon/icon.service.ts	Migrated all constructor parameters to `inject()`

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

dkamburov · 2025-11-13T13:16:48Z

@copilot can you do deep review on the PR and the tests modifieid

Copilot · 2025-11-13T13:16:56Z

@dkamburov I've opened a new pull request, #16453, to work on those changes. Once the pull request is ready, I'll request review from you.

…ctor-to-inject

...s/igniteui-angular/directives/src/directives/scroll-inertia/scroll_inertia.directive.spec.ts

projects/igniteui-angular/grids/core/src/state-base.directive.ts

projects/igniteui-angular/grids/grid/src/grid.master-detail.spec.ts

projects/igniteui-angular/test-utils/grid-base-components.spec.ts

projects/igniteui-angular-elements/src/lib/state.component.ts

projects/igniteui-angular/combo/src/combo/combo.component.spec.ts

...niteui-angular/directives/src/directives/date-time-editor/date-time-editor.directive.spec.ts

projects/igniteui-angular/stepper/src/stepper/stepper.component.spec.ts

...niteui-angular/directives/src/directives/date-time-editor/date-time-editor.directive.spec.ts

projects/igniteui-angular/stepper/src/stepper/stepper.component.spec.ts

…ctor-to-inject

Copilot

Pull request overview

Copilot reviewed 274 out of 274 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

dkamburov · 2025-11-25T15:55:50Z

@IMinchev64 conflicts again :(
Also please review(apply or dismiss) the findings from the code-quality bot.

…-inject

dkamburov · 2025-11-26T13:49:59Z

projects/igniteui-angular/directives/src/directives/toggle/toggle.directive.spec.ts

@@ -1,4 +1,4 @@
-import { ChangeDetectionStrategy, Component, DebugElement, ViewChild, ElementRef, OnInit } from '@angular/core';
+import { ChangeDetectionStrategy, Component, DebugElement, ViewChild, ElementRef, OnInit, inject as inject_1 } from '@angular/core';


why this is renamed to inject_1?

dkamburov · 2025-11-26T13:56:54Z

@IMinchev64 please update these as well.

…ctor-to-inject

IMinchev64 added 7 commits July 24, 2025 17:03

refactor(*): migrate DI from constructors to inject() API

96c126e

refactor(*): change tests to account for new DI

0c65ec8

refactor(*): change tests to account for new DI

0991fd0

refactor(*): change tests to account for new DI

ce346e7

refactor(*): change tests to account for new DI

5b40832

fix(*): wrong injected service

b3bf2de

fix(*): remove fdescribe

1952455

IMinchev64 marked this pull request as ready for review August 11, 2025 12:12

IMinchev64 and others added 13 commits September 15, 2025 12:22

Merge remote-tracking branch 'origin/master' into iminchev/di-constru…

3fbd906

…ctor-to-inject

fix(*): minor changes to fix build errors

27598e6

fix(*): failing tests after di refactor

633493a

Merge remote-tracking branch 'origin/master' into iminchev/di-constru…

e866c6a

…ctor-to-inject

fix(*): build and lint errors

a584020

fix(*): elements build issue

d827e87

chore(elements): update config via script

8a30e57

fix(elements): fix failing tests due to missing providers

f11d24f

fix(*): fix grid dependency for elements state component

422b113

chore(hgrid): remove console log

20bfcaf

test(grid): add tick to avoid test pollution

804f743

Merge remote-tracking branch 'origin/master' into iminchev/di-constru…

059b7ca

…ctor-to-inject

Merge branch 'master' into iminchev/di-constructor-to-inject

dd14e54

dkamburov requested a review from Copilot November 13, 2025 09:41

Copilot AI reviewed Nov 13, 2025

View reviewed changes

Copilot AI mentioned this pull request Nov 13, 2025

Deep review analysis of DI migration from constructors to inject() API #16453

Closed

Merge remote-tracking branch 'origin/master' into iminchev/di-constru…

424a004

…ctor-to-inject

github-code-quality bot found potential problems Nov 20, 2025

View reviewed changes

ChronosSF added the triage: blocking label Nov 21, 2025

fix(*): address build errors and lint warnings

c5a9f9c

github-code-quality bot found potential problems Nov 24, 2025

View reviewed changes

...niteui-angular/directives/src/directives/date-time-editor/date-time-editor.directive.spec.ts Fixed Show fixed Hide fixed

projects/igniteui-angular/stepper/src/stepper/stepper.component.spec.ts Fixed Show fixed Hide fixed

IMinchev64 added 2 commits November 24, 2025 14:38

fix(*): fix incorrect inject

e54a913

Merge remote-tracking branch 'origin/master' into iminchev/di-constru…

dcab158

…ctor-to-inject

ChronosSF requested a review from Copilot November 25, 2025 09:23

Copilot AI reviewed Nov 25, 2025

View reviewed changes

ChronosSF requested review from ChronosSF, dkamburov and skrustev November 25, 2025 09:25

Merge branch 'master' into iminchev/di-constructor-to-inject

ec017ea

IMinchev64 added 3 commits November 26, 2025 11:01

Merge remote-tracking branch 'origin' into iminchev/di-constructor-to…

bf278ae

…-inject

chore(*): fix lint warnings

238cf57

refactor(*): clean up imports and fix formatting in component specs

348fc8c

dkamburov reviewed Nov 26, 2025

View reviewed changes

IMinchev64 and others added 3 commits November 27, 2025 14:31

chore(*): fix strange import

c6eed17

docs(*): update changelog

3586ba4

Merge remote-tracking branch 'origin/master' into iminchev/di-constru…

5a76239

…ctor-to-inject

dkamburov approved these changes Nov 28, 2025

View reviewed changes

dkamburov merged commit 661153b into master Nov 28, 2025
7 checks passed

dkamburov deleted the iminchev/di-constructor-to-inject branch November 28, 2025 13:52

		@@ -1,4 +1,4 @@
		import { ChangeDetectionStrategy, Component, DebugElement, ViewChild, ElementRef, OnInit } from '@angular/core';
		import { ChangeDetectionStrategy, Component, DebugElement, ViewChild, ElementRef, OnInit, inject as inject_1 } from '@angular/core';

Conversation

IMinchev64 commented Jul 24, 2025

Additional information (check all that apply):

Checklist:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

dkamburov commented Nov 13, 2025

Uh oh!

Copilot AI commented Nov 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

dkamburov commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dkamburov Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

dkamburov commented Nov 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dkamburov commented Nov 25, 2025 •

edited

Loading