chore(migrations): json schemas upkeep#16239
Merged
Conversation
Lipata
previously approved these changes
Sep 24, 2025
|
There has been no recent activity and this PR has been marked inactive. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs maintenance on JSON schema files by regenerating them and removing an obsolete schema file (theme-props.schema.json) that is no longer used due to theme-related changes in the codebase.
Key Changes:
- Removed the obsolete
theme-props.schema.jsonfile - Added missing
requiredfields to various schema definitions for better validation - Reordered enum values alphabetically in multiple schemas
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
theme-props.schema.json |
Removed obsolete schema file for theme properties |
theme-changes.schema.json |
Added required fields and reordered enum values alphabetically |
selector.schema.json |
Reordered ElementType enum values alphabetically |
index.ts |
Updated schema generation command comment |
imports.schema.json |
Restructured to add definitions wrapper and required fields |
class.schema.json |
Updated JSON schema version from draft-06 to draft-07 |
binding.schema.json |
Reordered ElementType enum values alphabetically |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lipata
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran generation on JSON Schema files and removed obsolete one for theme props (theme changes in use).
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)